You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/09 11:57:09 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #889: Improve testing/fstest
xiaoxiang781216 opened a new pull request #889:
URL: https://github.com/apache/incubator-nuttx-apps/pull/889
## Summary
## Impact
fstest
## Testing
run fstest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei merged pull request #889: Improve testing/fstest
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #889:
URL: https://github.com/apache/incubator-nuttx-apps/pull/889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on pull request #889: Improve testing/fstest
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #889:
URL: https://github.com/apache/incubator-nuttx-apps/pull/889#issuecomment-980599676
> @gustavonihei do you have more suggestion?
No more comments, sorry for missing this PR. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #889: Improve testing/fstest
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #889:
URL: https://github.com/apache/incubator-nuttx-apps/pull/889#discussion_r745578773
##########
File path: testing/fstest/fstest_main.c
##########
@@ -969,7 +959,7 @@ static void show_useage(void)
printf("Usage : fstest [OPTION [ARG]] ...\n");
printf("-h show this help statement\n");
printf("-n num of test loop e.g. [%d]\n", CONFIG_TESTING_FSTEST_NLOOPS);
- printf("-m mount point tobe test e.g. [%s]\n",
+ printf("-m mount point to be test e.g. [%s]\n",
Review comment:
```suggestion
printf("-m mount point to be tested e.g. [%s]\n",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #889: Improve testing/fstest
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #889:
URL: https://github.com/apache/incubator-nuttx-apps/pull/889#discussion_r745597564
##########
File path: testing/fstest/fstest_main.c
##########
@@ -969,7 +959,7 @@ static void show_useage(void)
printf("Usage : fstest [OPTION [ARG]] ...\n");
printf("-h show this help statement\n");
printf("-n num of test loop e.g. [%d]\n", CONFIG_TESTING_FSTEST_NLOOPS);
- printf("-m mount point tobe test e.g. [%s]\n",
+ printf("-m mount point to be test e.g. [%s]\n",
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #889: Improve testing/fstest
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #889:
URL: https://github.com/apache/incubator-nuttx-apps/pull/889#issuecomment-980566463
@gustavonihei do you have more suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org