You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/12/07 12:00:38 UTC
[PR] [WIP][SPARK-40353][PS][TESTS] Re-enable the `read_excel` tests [spark]
itholic opened a new pull request, #44238:
URL: https://github.com/apache/spark/pull/44238
### What changes were proposed in this pull request?
This PR proposes to re-enable the `read_excel` tests
### Why are the changes needed?
To improve the test coverage
### Does this PR introduce _any_ user-facing change?
No, it's test-only.
### How was this patch tested?
Enabled the skipped tests and manually run
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-40353][PS][TESTS] Re-enable the `read_excel` tests [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #44238:
URL: https://github.com/apache/spark/pull/44238#issuecomment-1845219336
Let me wait for CI running since it was failed with unknown reason only in GitHub Actions before. See https://github.com/apache/spark/pull/37671#issuecomment-1237515485 for detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-40353][PS][TESTS] Re-enable the `read_excel` tests [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #44238:
URL: https://github.com/apache/spark/pull/44238#issuecomment-1846561202
Yeah, seems like this still doesn't work on GitHub CI. It's wired but let me close PR for now since I couldn't catch any clue for this failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-40353][PS][TESTS] Re-enable the `read_excel` tests [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic closed pull request #44238: [WIP][SPARK-40353][PS][TESTS] Re-enable the `read_excel` tests
URL: https://github.com/apache/spark/pull/44238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org