[jira] [Commented] (NIFI-4652) NiFi pom profiles use of activeByDefault does not work as expected and many maven plugin versions are very out of date

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276143#comment-16276143 ] 

ASF GitHub Bot commented on NIFI-4652:
--------------------------------------

GitHub user joewitt opened a pull request:

    https://github.com/apache/nifi/pull/2313

    NIFI-4652 updating to latest apache version and updating key maven pl…

    Not for review yet.  Helping currently with validation on various systems.  Will squash and notify before review.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joewitt/incubator-nifi NIFI-4652

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2313
    
----
commit 78a16cf019c2d0c2b4a2293d6fa68e64100a1de5
Author: joewitt <jo...@apache.org>
Date:   2017-12-03T22:45:03Z

    NIFI-4652 updating to latest apache version and updating key maven plugins

----


> NiFi pom profiles use of activeByDefault does not work as expected and many maven plugin versions are very out of date
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4652
>                 URL: https://issues.apache.org/jira/browse/NIFI-4652
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Joseph Witt
>            Assignee: Joseph Witt
>             Fix For: 1.5.0
>
>
> In working NIFI-4645 we've found profiles dont' quite work as expected due to the maven behavior for profiles with 'activeByDefault' being automatically disabled anytime other methods of activation activate any other profile within the same pom.  This leads to builds not working as we expect.  Need to audit, improve, and document a new profile management strategy.
> Further, in reviewing this it is found that many many of our maven plugins are very old/out of date and can benefit from being brought up to date including the org.apache:apache version (latest is 18 and released more than a year ago) and maven compiler which we use 3.2 and latest is 3.7.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)