You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/06/23 13:09:47 UTC

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18660


Change subject: IMPALA-9823: Make use_local_catalog and related flags visible
......................................................................

IMPALA-9823: Make use_local_catalog and related flags visible

use_local_catalog and related flags shouldn't be hidden and should be
show up on the Web UI. This makes them visible. Also updates the
description of use_local_catalog.

Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
---
M be/src/runtime/exec-env.cc
M tests/common/environ.py
2 files changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/18660/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
Gerrit-Change-Number: 18660
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 )

Change subject: IMPALA-9823: Make use_local_catalog and related flags visible
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
Gerrit-Change-Number: 18660
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 14:42:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 )

Change subject: IMPALA-9823: Make use_local_catalog and related flags visible
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
Gerrit-Change-Number: 18660
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Oct 2022 04:11:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18660 )

Change subject: IMPALA-9823: Make use_local_catalog and related flags visible
......................................................................

IMPALA-9823: Make use_local_catalog and related flags visible

use_local_catalog and related flags shouldn't be hidden and should be
show up on the Web UI. This makes them visible. Also updates the
description of use_local_catalog.

Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
Reviewed-on: http://gerrit.cloudera.org:8080/18660
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/exec-env.cc
M tests/common/environ.py
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
Gerrit-Change-Number: 18660
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 )

Change subject: IMPALA-9823: Make use_local_catalog and related flags visible
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10848/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
Gerrit-Change-Number: 18660
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 13:30:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 )

Change subject: IMPALA-9823: Make use_local_catalog and related flags visible
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8665/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
Gerrit-Change-Number: 18660
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 23:04:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 )

Change subject: IMPALA-9823: Make use_local_catalog and related flags visible
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083
Gerrit-Change-Number: 18660
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 23:04:26 +0000
Gerrit-HasComments: No