[GitHub] spark pull request: [SPARK-5095] [Mesos] Support launching multipl...

[dragos <gi...@git.apache.org>]

Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10993#discussion_r51404529
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala ---
    @@ -65,17 +65,10 @@ private[spark] class CoarseMesosSchedulerBackend(
       private val shuffleServiceEnabled = conf.getBoolean("spark.shuffle.service.enabled", false)
     
       // Cores we have acquired with each Mesos task ID
    -  val coresByTaskId = new HashMap[Int, Int]
    +  val coresByTaskId = new HashMap[String, Int]
       var totalCoresAcquired = 0
     
    -  val slaveIdsWithExecutors = new HashSet[String]
    -
    -  // Maping from slave Id to hostname
    -  private val slaveIdToHost = new HashMap[String, String]
    -
    -  val taskIdToSlaveId: HashBiMap[Int, String] = HashBiMap.create[Int, String]
    -  // How many times tasks on each slave failed
    -  val failuresBySlaveId: HashMap[String, Int] = new HashMap[String, Int]
    +  private val slaves = new HashMap[String, Slave]
    --- End diff --
    
    Not a big issue, but I wonder if `slaveInfo` would be a better name. Also, a one-line comment to explain what the key is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org