You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/24 09:50:50 UTC
[GitHub] [airflow] auvipy opened a new pull request #9496: update celery and kombu
auvipy opened a new pull request #9496:
URL: https://github.com/apache/airflow/pull/9496
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] auvipy closed pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
auvipy closed pull request #9496:
URL: https://github.com/apache/airflow/pull/9496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-661724930
> do we need that? it's showing all are passing
Only static checks has passed. To optimize the builds we do not run tests with "docs" changes. That was fixed in #9690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek edited a comment on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
turbaszek edited a comment on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-654215791
@auvipy once this one https://github.com/apache/airflow/pull/9690 is merged will you be able to rebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#discussion_r464398249
##########
File path: requirements/requirements-python3.8.txt
##########
@@ -80,7 +80,7 @@ cached-property==1.5.1
cachetools==4.1.0
cassandra-driver==3.20.2
cattrs==1.0.0
-celery==4.4.5
+celery==4.4.6
Review comment:
```suggestion
celery==4.4.7
```
@auvipy should we try?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] auvipy commented on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
auvipy commented on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-648766414
this release fixes some regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-661105459
@auvipy would you mind rebasing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-654215791
@auvipy once this one https://github.com/apache/airflow/pull/9690 will you be able to rebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-651305850
@kaxil @potiuk should we merge or run all tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-651310393
Yeah. Adding an artificial plugin change for now should do the trick. Alternatively (And possibly better) add requirements/* to the regexp here; https://github.com/apache/airflow/blob/master/.github/workflows/ci.yml#L169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] auvipy commented on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
auvipy commented on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-654231601
sure just ping me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] auvipy commented on pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
auvipy commented on pull request #9496:
URL: https://github.com/apache/airflow/pull/9496#issuecomment-661688697
do we need that? it's showing all are passing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #9496: update celery and kombu
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #9496:
URL: https://github.com/apache/airflow/pull/9496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org