You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ph...@apache.org on 2010/04/14 20:36:51 UTC

svn commit: r934099 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

Author: philip
Date: Wed Apr 14 18:36:50 2010
New Revision: 934099

URL: http://svn.apache.org/viewvc?rev=934099&view=rev
Log:
* subversion/libsvn_fs_fs/fs_fs.c
  (svn_fs_fs__hotcopy): Add comment, no functional change.

Modified:
    subversion/trunk/subversion/libsvn_subr/sqlite.c

Modified: subversion/trunk/subversion/libsvn_subr/sqlite.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/sqlite.c?rev=934099&r1=934098&r2=934099&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/sqlite.c (original)
+++ subversion/trunk/subversion/libsvn_subr/sqlite.c Wed Apr 14 18:36:50 2010
@@ -1001,6 +1001,12 @@ svn_sqlite__hotcopy(const char *src_path
            number of pages an order of magnitude higher, this is still
            likely to be a fraction of large databases. */
         rc1 = sqlite3_backup_step(backup, 1024);
+
+        /* Should we sleep on SQLITE_OK?  That would make copying a
+           large database take much longer.  When we do sleep how,
+           long should we sleep?  Should the sleep get longer if we
+           keep getting BUSY/LOCKED?  I have no real reason for
+           choosing 25. */
         if (rc1 == SQLITE_BUSY || rc1 == SQLITE_LOCKED)
           sqlite3_sleep(25);
       }