[GitHub] [lucene] jdconrad commented on pull request #12016: Upgrade ANTLR to version 4.11.1

[GitBox <gi...@apache.org>]

jdconrad commented on PR #12016:
URL: https://github.com/apache/lucene/pull/12016#issuecomment-1350071474

   I agree with @rmuir that having an ambiguity check for tests similar to Painless would be great for expressions. I'm a bit surprised this change didn't require much additionally to the regeneration of the lexer/grammar. One other thing I'm curious about is if this suffers from the same issue that Painless did with multiple nested conditionals (https://github.com/elastic/elasticsearch/pull/52056). So that may be something else worth adding a test for. Thanks for looking into upgrading this @reta!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org