You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Piyush Hari (JIRA)" <ad...@incubator.apache.org> on 2006/10/28 00:33:58 UTC
[jira] Created: (ADFFACES-266) goButton on PDAs should be rendererd
as a linked button and not a button
goButton on PDAs should be rendererd as a linked button and not a button
------------------------------------------------------------------------
Key: ADFFACES-266
URL: http://issues.apache.org/jira/browse/ADFFACES-266
Project: MyFaces ADF-Faces
Issue Type: Improvement
Environment: PDA
Reporter: Piyush Hari
Priority: Minor
At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
String element = useButtonTag ? "button" : "a";
I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-266) goButton on PDAs should be
rendererd as a linked button and not a button
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494972 ]
Piyush Hari commented on ADFFACES-266:
--------------------------------------
Jeanne,
I had brought it up earlier on the list when I submitted the patch. Adam replied saying that "a href" was used instead of "input" because he thought that all devices other than desktop where there is no JS support can use links atleast. PDAs DO HAVE JS support. Therefore , I have "input" element.
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: https://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-266) goButton on PDAs should be rendererd
as a linked button and not a button
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-266?page=all ]
Piyush Hari updated ADFFACES-266:
---------------------------------
Attachment: patch_oct27_05_33PM_goButton_pda.patch
I am providing the patch to fix this issue. (patch_oct27_05_33PM_goButton_pda.patch). goButton is now rendered as an input html element instead of a link on PDAs
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: http://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-266) goButton on PDAs should be
rendererd as a linked button and not a button
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494924 ]
Jeanne Waldman commented on ADFFACES-266:
-----------------------------------------
Hi Piyush,
It seems a little heavy-handed to switch it from <a> to <input>. It might be the case for pdas that input is better than a, but maybe there are other reasons why we'd want to use an a.
boolean useButtonTag = useButtonTags(arc);
String element = useButtonTag ? "button" : "a"; // you have "input" instead of "a".
protected boolean useButtonTags(RenderingContext arc)
{
return (supportsScripting(arc) &&
supportsAdvancedForms(arc) &&
supportsIntrinsicEvents(arc));
}
Can you bring this up on the dev list to be sure? If we can't be sure, then we should only switch to input in the case of pda.
- Jeanne
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: https://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-266) goButton on PDAs should be
rendererd as a linked button and not a button
Posted by "Blake Sullivan (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495116 ]
Blake Sullivan commented on ADFFACES-266:
-----------------------------------------
I assume that the problem is that supportsAdvancedForms(arc) is returning false for your Agent because your agent doesn't support <button>. In that case we really want useButtonTags to be able to return a value indicating the three choices, <a>, <button>, or <input>. If we don't care about subclasses (of which there are none in Trinidad), the easiest thing to do would be to inline useButtonTags into the one place where it is called.
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: https://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-266) goButton on PDAs should be rendererd
as a linked button and not a button
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-266?page=all ]
Piyush Hari updated ADFFACES-266:
---------------------------------
Status: Patch Available (was: Open)
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: http://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (ADFFACES-266) goButton on PDAs should be rendererd
as a linked button and not a button
Posted by Blake Sullivan <bl...@oracle.com>.
Jeanne Waldman (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495100 ]
>
> Jeanne Waldman commented on ADFFACES-266:
> -----------------------------------------
>
> Yes, but what about all the devices that do not support JS? You've changed "a" to "input" for everything, not just for PDA.
>
I completely agree with Jeanne. The question is why doesn't:
protected boolean useButtonTags(RenderingContext arc)
{
return (supportsScripting(arc) &&
supportsAdvancedForms(arc) &&
supportsIntrinsicEvents(arc));
}
return true for your PDA?
-- Blake Sullivan
>
>> goButton on PDAs should be rendererd as a linked button and not a button
>> ------------------------------------------------------------------------
>>
>> Key: ADFFACES-266
>> URL: https://issues.apache.org/jira/browse/ADFFACES-266
>> Project: MyFaces ADF-Faces
>> Issue Type: Improvement
>> Environment: PDA
>> Reporter: Piyush Hari
>> Priority: Minor
>> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>>
>>
>> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>>
>> String element = useButtonTag ? "button" : "a";
>>
>> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'.
>>
>
>
[jira] Commented: (ADFFACES-266) goButton on PDAs should be
rendererd as a linked button and not a button
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495100 ]
Jeanne Waldman commented on ADFFACES-266:
-----------------------------------------
Yes, but what about all the devices that do not support JS? You've changed "a" to "input" for everything, not just for PDA.
> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
> Key: ADFFACES-266
> URL: https://issues.apache.org/jira/browse/ADFFACES-266
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct27_05_33PM_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag :
>
> String element = useButtonTag ? "button" : "a";
>
> I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.