[jira] [Commented] (ZOOKEEPER-3063) Track outstanding changes with ArrayDeque

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513014#comment-16513014 ] 

Hadoop QA commented on ZOOKEEPER-3063:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1831//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1831//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1831//console

This message is automatically generated.

> Track outstanding changes with ArrayDeque
> -----------------------------------------
>
>                 Key: ZOOKEEPER-3063
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3063
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Yisong Yue
>            Assignee: Yisong Yue
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 3.6.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Outstanding changes are tracked with an ArrayList, which has O(N) remove from head (and possibly add) performance. This means that as we get further behind, we will slow down the processing of outstanding changes, which would make us get further behind.
>  We should switch to using ArrayDeque which achieves O(1) add and remove on both ends, which should result in much happiness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)