[GitHub] [lucenenet] NightOwl888 opened a new pull request, #733: OfflineSorter Updates

[GitBox <gi...@apache.org>]

NightOwl888 opened a new pull request, #733:
URL: https://github.com/apache/lucenenet/pull/733

   - **BUG:** `Lucene.Net.Util.OfflineSorter`: Fixed the `Sort()` and `SortPartition()` methods so they use the `tempDirectory` parameter that is passed through the constructor, as was the case in Lucene. 
   - `Lucene.Net.Util.OfflineSorter`: Added a constructor overload to specify the directory as a string (a .NET convention).
   - **BREAKING:** `Lucene.Net.Util.OfflineSorter`: Changed `DefaultTempDir()` > `GetDefaultTempDir()`. Marked `DefaultTempDir()` obsolete.
   - `Lucene.Net.Util.OfflineSorter`: Added guard clauses (and removed asserts). 
   - `Lucene.Net.Util.OfflineSorter`: Enabled nullable reference type support. 
   - `Lucene.Net.Util.OfflineSorter`: Added disposed flag to ensure dispose only happens once.
   - `Lucene.Net.Util.OfflineSorter (ByteSequencesReader + ByteSequencesWriter)`: Added constructor overloads to pass the file name as a string (.NET convention)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 merged pull request #733: OfflineSorter Updates

[GitBox <gi...@apache.org>]

NightOwl888 merged PR #733:
URL: https://github.com/apache/lucenenet/pull/733


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org