You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/04 02:02:43 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4084: Added nfs minor version support on SSVM

rhtyd commented on a change in pull request #4084:
URL: https://github.com/apache/cloudstack/pull/4084#discussion_r434950551



##########
File path: engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java
##########
@@ -73,16 +73,26 @@
                     "If set to true, creates VMs as full clones on ESX hypervisor",
                     true,
                     ConfigKey.Scope.StoragePool);
-    static final ConfigKey<Integer> ImageStoreNFSVersion =
+    static final ConfigKey<Integer> ImageStoreNFSMajorVersion =

Review comment:
       @Spaceman1984 can you revert the change, why not parse for the major and minor version? Something like `x.y` could be parsed by splitting on the `.` if provided.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org