[jira] [Commented] (ISIS-984) Make it possible to use custom icons, not only FontAwesome ones

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263564#comment-14263564 ] 

Martin Grigorov commented on ISIS-984:
--------------------------------------

This will have to be implemented with a special method (e.g. #icon(), like current #iconName()) because it won't be possible to encode Icon class as annotation attribute in ActionLayout.

[~danhaywood] Any reason why *iconName* is not an attribute in ActionLayout but it a special method ?

> Make it possible to use custom icons, not only FontAwesome ones
> ---------------------------------------------------------------
>
>                 Key: ISIS-984
>                 URL: https://issues.apache.org/jira/browse/ISIS-984
>             Project: Isis
>          Issue Type: Improvement
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.8.0
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: viewer-wicket-1.9.0
>
>
> See discussion at: http://markmail.org/message/nhm7eflnrru2rvcr
> The idea is to replace ActionLayout#cssClassFa and ActionLayout#cssClassFaPosition with ActionLayout#icon.
> Icon will be an interface/abstract class.
> Isis will provide impl for FontAwesome.
> Each application will be able to provide its own impl for any icon type it needs/wants to use (e.g. http://icons8.com/, http://glyphsearch.com/, http://glyphsearch.com/, etc.). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)