[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1012: Move TCL test unit/tls to Go case

[GitBox <gi...@apache.org>]

PragmaTwice commented on code in PR #1012:
URL: https://github.com/apache/incubator-kvrocks/pull/1012#discussion_r999390646


##########
tests/gocase/util/server.go:
##########
@@ -181,11 +238,19 @@ func StartServer(t testing.TB, configs map[string]string) *KvrocksServer {
 
 	c := redis.NewClient(&redis.Options{Addr: addr.String()})
 	defer func() { require.NoError(t, c.Close()) }()
+
+	proc, err := process.NewProcess(int32(cmd.Process.Pid))
+	require.NoError(t, err)
+
+	procStatus := []string{}
 	require.Eventually(t, func() bool {
 		err := c.Ping(context.Background()).Err()
-		return err == nil || err.Error() == "NOAUTH Authentication required."
+		procStatus, _ = proc.Status()
+		return err == nil || err.Error() == "NOAUTH Authentication required." || reflect.DeepEqual(procStatus, []string{process.Zombie})

Review Comment:
   If kvrocks aborted due to an config error or whatever, we can exit the ping loop quickly rather than waiting 1 minute.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org