You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2026/07/11 04:11:40 UTC
[PR] cripts: build against fmt 11+ (incl. 12.x) [trafficserver]
zwoop opened a new pull request, #13375:
URL: https://github.com/apache/trafficserver/pull/13375
fmt 11 dropped fmt::format/vformat from fmt/core.h; include fmt/format.h instead, and use fmt::format directly to avoid a deprecated format_string conversion. Still builds on fmt 8.1+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cripts: build against fmt 11+ (incl. 12.x) [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop merged PR #13375:
URL: https://github.com/apache/trafficserver/pull/13375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cripts: build against fmt 11+ (incl. 12.x) [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #13375:
URL: https://github.com/apache/trafficserver/pull/13375#discussion_r3564705644
##########
include/cripts/Instance.hpp:
##########
@@ -106,7 +106,7 @@ class Instance
debug(fmt::format_string<T...> fmt, T &&...args) const
{
if (DebugOn()) {
- auto str = fmt::vformat(fmt, fmt::make_format_args(args...));
+ auto str = fmt::format(fmt, std::forward<T>(args)...);
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cripts: build against fmt 11+ (incl. 12.x) [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13375:
URL: https://github.com/apache/trafficserver/pull/13375#issuecomment-5111126998
Cherry-picked to 10.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cripts: build against fmt 11+ (incl. 12.x) [trafficserver]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13375:
URL: https://github.com/apache/trafficserver/pull/13375#discussion_r3563128936
##########
include/cripts/Instance.hpp:
##########
@@ -106,7 +106,7 @@ class Instance
debug(fmt::format_string<T...> fmt, T &&...args) const
{
if (DebugOn()) {
- auto str = fmt::vformat(fmt, fmt::make_format_args(args...));
+ auto str = fmt::format(fmt, std::forward<T>(args)...);
Review Comment:
`Instance::debug()` now calls `fmt::format()` and uses `std::forward()`, but `Instance.hpp` does not include `<fmt/format.h>` (for `fmt::format`) or `<utility>` (for `std::forward`). This makes the header fragile and can break compilation depending on include order (e.g. `cripts/Context.hpp` includes `cripts/Instance.hpp` without pulling in `cripts/Lulu.hpp`). Add the missing includes directly to `Instance.hpp` to make it self-contained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org