You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/27 07:10:35 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request #5712: [Bug] Fix bug that Drop olap table when table'state is not normal may introduce some problems
caiconghui opened a new pull request #5712:
URL: https://github.com/apache/incubator-doris/pull/5712
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #5711 ) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui edited a comment on pull request #5712: [Bug] Fix bug that Drop olap table when table'state is not normal may introduce some problems
Posted by GitBox <gi...@apache.org>.
caiconghui edited a comment on pull request #5712:
URL: https://github.com/apache/incubator-doris/pull/5712#issuecomment-827551942
> Isn't it a bit unfriendly to not allow drop table, because the user may just want to drop the table due to some abnormality of the table.
> After the table is dropped, it is reasonable to say that the task of schema change should directly fail. Why will it continue to be executed?
if user want to use table again, the table should keep normal when recovered, but if schema change job not set table to be normal again, table will never be normal agagin.
In fact, in a stand-alone environment, the table cannot be discarded because the table lock is held during the schema change operation. Because we consider performance here, the table lock is released part of the time during the entire execution of the schema change. Here we only need to cancel the alter table operation in time to drop successfully
schema change should not directly fail, because some operation should not be interrupted, set table to be normal, clear unneeded tablet and so on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui edited a comment on pull request #5712: [Bug] Fix bug that Drop olap table when table'state is not normal may introduce some problems
Posted by GitBox <gi...@apache.org>.
caiconghui edited a comment on pull request #5712:
URL: https://github.com/apache/incubator-doris/pull/5712#issuecomment-827551942
> Isn't it a bit unfriendly to not allow drop table, because the user may just want to drop the table due to some abnormality of the table.
> After the table is dropped, it is reasonable to say that the task of schema change should directly fail. Why will it continue to be executed?
if user want to use table again, the table should keep normal when recovered, but if schema change job not set table to be normal again, table will never be normal agagin.
In fact, in a stand-alone environment, the table cannot be discarded because the table lock is held during the schema change operation. Because we consider performance here, the table lock is released part of the time during the entire execution of the schema change. Here we only need to cancel the alter table operation in time to drop successfully
schema change should not directly fail, because some operation should not be interrupted, set table to be normal, clear unneeded tablet and so on
if user really not need table anymore, he can use drop table force stmt which will clear all table meta immediatly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #5712: [Bug] Fix bug that Drop olap table when table'state is not normal may introduce some problems
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #5712:
URL: https://github.com/apache/incubator-doris/pull/5712#issuecomment-827546537
Isn't it a bit unfriendly to not allow drop table, because the user may just want to drop the table due to some abnormality of the table.
After the table is dropped, it is reasonable to say that the task of schema change should directly fail. Why will it continue to be executed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5712: [Bug] Fix bug that Drop olap table may introduce some problems when table's state is not normal
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5712:
URL: https://github.com/apache/incubator-doris/pull/5712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #5712: [Bug] Fix bug that Drop olap table when table'state is not normal may introduce some problems
Posted by GitBox <gi...@apache.org>.
caiconghui commented on pull request #5712:
URL: https://github.com/apache/incubator-doris/pull/5712#issuecomment-827551942
> Isn't it a bit unfriendly to not allow drop table, because the user may just want to drop the table due to some abnormality of the table.
> After the table is dropped, it is reasonable to say that the task of schema change should directly fail. Why will it continue to be executed?
if user want to use table again, the table should keep normal when recovered, but if schema change job not set table to be normal again, table will never be normal agagin.
In fact, in a stand-alone environment, the table cannot be discarded because the table lock is held during the schema change operation. Because we consider performance here, the table lock is released part of the time during the entire execution of the schema change. Here we only need to cancel the alter table operation in time to drop successfully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org