You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2020/09/01 01:12:31 UTC
[spark] branch branch-3.0 updated: [MINOR][R] Fix a R style in try
and finally at DataFrame.R
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 3a516ae [MINOR][R] Fix a R style in try and finally at DataFrame.R
3a516ae is described below
commit 3a516ae68c773668edf966474e61a208a51a2f96
Author: Lu WANG <lu...@databricks.com>
AuthorDate: Tue Sep 1 10:07:34 2020 +0900
[MINOR][R] Fix a R style in try and finally at DataFrame.R
Fix the R style issue which is not catched by the R style checker. Got error:
```
R/DataFrame.R:1244:17: style: Closing curly-braces should always be on their own line, unless it's followed by an else.
}, finally = {
^
lintr checks failed.
```
Closes #29574 from lu-wang-dl/fix-r-style.
Lead-authored-by: Lu WANG <lu...@databricks.com>
Co-authored-by: Lu Wang <38...@users.noreply.github.com>
Signed-off-by: HyukjinKwon <gu...@apache.org>
(cherry picked from commit 701e5934140e477426cf2a68f2c5746be67418d6)
Signed-off-by: HyukjinKwon <gu...@apache.org>
---
R/pkg/R/DataFrame.R | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/R/pkg/R/DataFrame.R b/R/pkg/R/DataFrame.R
index 3a60d1c..4195ec8f 100644
--- a/R/pkg/R/DataFrame.R
+++ b/R/pkg/R/DataFrame.R
@@ -1240,7 +1240,8 @@ setMethod("collect",
arrowTable <- arrow::read_arrow(readRaw(conn))
}
as.data.frame(arrowTable, stringsAsFactors = stringsAsFactors)
- }, finally = {
+ },
+ finally = {
close(conn)
})
return(output)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org