You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "UngureanuSerg (via GitHub)" <gi...@apache.org> on 2023/03/19 18:14:42 UTC
[GitHub] [druid] UngureanuSerg opened a new issue, #13948: JUnit4 to JUnit5 migration
UngureanuSerg opened a new issue, #13948:
URL: https://github.com/apache/druid/issues/13948
Hi team,
A proposal to moving on after the adoption of java8+ is to start the migration from junit4 to jnuit5.
- JUnit 4 never advanced beyond Java 7, missing out on a lot of features from Java 8. JUnit 5 makes good use of the Java 8 features.
- A single jar library contains the entire framework. We need to import the whole library, even when we only require a particular feature. In JUnit 5, we get more granularity and can import only what's necessary.
- Only one test runner can execute tests at a time in JUnit 4 (e.g. @RunWith(Parameterized.class)
or provide druid extension with the adoption of JUnit Platform). JUnit 5 allows multiple runners to work simultaneously.
As a strategy for the apporach I would suggest to migrate one module at a time(it will be easier for the prs) and create tasks for the rest of the modules. As a strating point we can still depend on JUnit Vintage for backward compatibility with JUnit 4 but gradually moving to JUnit5.
I think all the point mentioned describes why it would be beneficial for apache druid as well as I would like to pick this issue if hte rest of the community is intrested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on issue #13948: JUnit4 to JUnit5 migration
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on issue #13948:
URL: https://github.com/apache/druid/issues/13948#issuecomment-1478829404
@UngureanuSerg Thanks for starting this. Yes lets start the migration. Pretty excited 🚀 .
IMHO `JUnit Vintage` should be our last option. If we are able to move to the JUnit 5 using `Unit Platform` dependencies that would be event cooler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dampcake commented on issue #13948: JUnit4 to JUnit5 migration
Posted by "dampcake (via GitHub)" <gi...@apache.org>.
dampcake commented on issue #13948:
URL: https://github.com/apache/druid/issues/13948#issuecomment-1487097596
In other projects I use junit-vintage to mix both JUnit5 and JUnit4 tests in the same suites. This allows for new tests or tests where you want to take advantage of the features to be converted while leaving all the existing tests on Junit4. Pretty much a best of both worlds scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on issue #13948: JUnit4 to JUnit5 migration
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on issue #13948:
URL: https://github.com/apache/druid/issues/13948#issuecomment-1486285977
> @UngureanuSerg Thanks for starting this. Yes lets start the migration. Pretty excited 🚀 .
> IMHO `JUnit Vintage` should be our last option. If we are able to move to the JUnit 5 using `Unit Platform` dependencies that would be event cooler.
I don't know the details, but if "JUnit Vintage" allows us to do a migration piece-by-piece instead of updating every test case at once, that sounds like a good thing. Updating every test case at once could potentially be a prohibitive amount of work for a single contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] UngureanuSerg commented on issue #13948: JUnit4 to JUnit5 migration
Posted by "UngureanuSerg (via GitHub)" <gi...@apache.org>.
UngureanuSerg commented on issue #13948:
URL: https://github.com/apache/druid/issues/13948#issuecomment-1486399623
Hey Gian I didn't know that junit-vintage give this kind of capabilities but I will check it for sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org