You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/20 01:18:58 UTC
[GitHub] [dolphinscheduler] code-ferry opened a new pull request, #10152: [Fix] Change the default value of the parameter 'block-until-connecte…
code-ferry opened a new pull request, #10152:
URL: https://github.com/apache/dolphinscheduler/pull/10152
## Purpose of the pull request
Change the default value of the parameter 'block-until-connected' for registry.
600ms may be too short that sometimes it cause exception like "RegistryException: zookeeper connect timeout".
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] code-ferry commented on pull request #10152: [Fix] Change the default value of the parameter 'block-until-connecte…
Posted by GitBox <gi...@apache.org>.
code-ferry commented on PR #10152:
URL: https://github.com/apache/dolphinscheduler/pull/10152#issuecomment-1132384624
> I think 600ms is a very long time for production environment. We should not increase it. If user really need it, they can modify it themself. @code-ferry
I agree with you that 600ms is enough. But sometimes zk is not in good status, and I met this exception memtioned above serveral times. I just think startring later seconds than starting failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10152: [Fix] Change the default value of the parameter 'block-until-connecte…
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10152:
URL: https://github.com/apache/dolphinscheduler/pull/10152#issuecomment-1132388213
> > I think 600ms is a very long time for production environment. We should not increase it. If user really need it, they can modify it themself. @code-ferry
>
> I agree with you that 600ms is enough. But sometimes zk is not in good status, and I met this exception memtioned above serveral times. I just think startring later seconds than starting failure.
In this scenario, it is recommended to deploy zookeeper in high availability mode instead of increase the zookeeper's timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] code-ferry closed pull request #10152: [Fix] Change the default value of the parameter 'block-until-connecte…
Posted by GitBox <gi...@apache.org>.
code-ferry closed pull request #10152: [Fix] Change the default value of the parameter 'block-until-connecte…
URL: https://github.com/apache/dolphinscheduler/pull/10152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] code-ferry commented on pull request #10152: [Fix] Change the default value of the parameter 'block-until-connecte…
Posted by GitBox <gi...@apache.org>.
code-ferry commented on PR #10152:
URL: https://github.com/apache/dolphinscheduler/pull/10152#issuecomment-1132398636
OK, Already high availability mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10152: [Fix] Change the default value of the parameter 'block-until-connecte…
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10152:
URL: https://github.com/apache/dolphinscheduler/pull/10152#issuecomment-1132430934
> I think 600ms is a very long time for production environment. We should not increase it. If user really need it, they can modify it themself. @code-ferry
Yeah, agree with @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10152: [Fix] Change the default value of the parameter 'block-until-connecte…
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10152:
URL: https://github.com/apache/dolphinscheduler/pull/10152#issuecomment-1132357137
I think 600ms is a very long time for production environment. We should not increase it. If user really need it, they can modify it themself. @code-ferry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org