[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #21083: [fix][broker] Cleanup correctly heartbeat bundle ownership when handling broker deletion event

["Demogorgon314 (via GitHub)" <gi...@apache.org>]

Demogorgon314 commented on code in PR #21083:
URL: https://github.com/apache/pulsar/pull/21083#discussion_r1312477267


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -1214,10 +1217,9 @@ private synchronized void doCleanup(String broker)  {
         int orphanServiceUnitCleanupCnt = 0;
         long totalCleanupErrorCntStart = totalCleanupErrorCnt.get();
         String heartbeatNamespace =
-                NamespaceService.getHeartbeatNamespace(pulsar.getAdvertisedAddress(), pulsar.getConfiguration())
-                        .toString();
-        String heartbeatNamespaceV2 = NamespaceService.getHeartbeatNamespaceV2(pulsar.getAdvertisedAddress(),
-                pulsar.getConfiguration()).toString();
+                NamespaceName.get(String.format(HEARTBEAT_NAMESPACE_FMT, config.getClusterName(), broker)).toString();

Review Comment:
   > Why does lookupServiceAddress need to be used here? (can you give us some example cases?)
   
   @heesung-sn Because we need to build heartbeat namespace for the needed cleanup broker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org