[GitHub] [nifi] joewitt commented on a diff in pull request #7826: NIFI-12157 Remove nifi-logging-utils and NiFiLog

["joewitt (via GitHub)" <gi...@apache.org>]

joewitt commented on code in PR #7826:
URL: https://github.com/apache/nifi/pull/7826#discussion_r1342167542


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/ClientResponseUtils.java:
##########
@@ -41,7 +40,7 @@ public static void drainClientResponse(final Response response) {
                 bis = new BufferedInputStream(response.readEntity(InputStream.class));
                 IOUtils.copy(bis, new NullOutputStream());
             } catch (final IOException ioe) {
-                logger.info("Failed clearing out non-client response buffer due to: " + ioe, ioe);
+                logger.info("Failed clearing out non-client response buffer", ioe);

Review Comment:
   We should avoid logging an exception at info level.  In this case the output should be warn as it happening would be interesting to know why we weren't able to drain the response.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org