You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/20 11:08:40 UTC

[GitHub] zentol commented on a change in pull request #7717: [FLINK-11533] [container] Add option parse JAR manifest for jobClassName

zentol commented on a change in pull request #7717: [FLINK-11533] [container] Add option parse JAR manifest for jobClassName
URL: https://github.com/apache/flink/pull/7717#discussion_r258433155
 
 

 ##########
 File path: flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactory.java
 ##########
 @@ -49,7 +49,9 @@
 		.required(true)
 
 Review comment:
   Wouldn't it be convenient if we used the manifest as a default fallback? I.e. work just like the normal job-submission; check manifest by default and optionally allow specifying the main-class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services