[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5828: Show assigned cpu in dump task and other fix for qemu rv

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5828:
URL: https://github.com/apache/incubator-nuttx/pull/5828#discussion_r832952564



##########
File path: arch/risc-v/src/qemu-rv/qemu_rv_irq_dispatch.c
##########
@@ -117,6 +117,34 @@ void *riscv_dispatch_irq(uintptr_t vector, uintptr_t *regs)
     }
 #endif
 
+#if defined(CONFIG_ARCH_FPU) || defined(CONFIG_ARCH_ADDRENV)

Review comment:
       split to the new PR

##########
File path: arch/risc-v/src/common/riscv_assert.c
##########
@@ -244,6 +250,9 @@ static inline void riscv_showtasks(void)
   /* Dump interesting properties of each task in the crash environment */
 
   _alert("   PID    PRI"
+#ifdef CONFIG_SMP
+         "   CPU"

Review comment:
       let's update riscv/xtensa too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org