You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "fangyincheng (GitHub)" <gi...@apache.org> on 2019/09/21 11:04:56 UTC
[GitHub] [dubbo-go] fangyincheng opened pull request #212: update
version and fix bug
**What this PR does**:
1. update getty&hessian version
2. fix bug about registryProtocol.Export
**Which issue(s) this PR fixes**:
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
[ Full content available at: https://github.com/apache/dubbo-go/pull/212 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #212: update
version and fix bug
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/212?src=pr&el=h1) Report
> Merging [#212](https://codecov.io/gh/apache/dubbo-go/pull/212?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dcbd9679cef41c0b6426b46fb4553193ffa3842c?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `38.46%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/212/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/212?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #212 +/- ##
===========================================
- Coverage 66.11% 65.96% -0.15%
===========================================
Files 96 96
Lines 6455 6459 +4
===========================================
- Hits 4268 4261 -7
- Misses 1743 1751 +8
- Partials 444 447 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/212?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/212/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `72.34% <0%> (-6.73%)` | :arrow_down: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/212/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.73% <100%> (ø)` | :arrow_up: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/212/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.37% <50%> (ø)` | :arrow_up: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/212/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/212/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/212/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/212?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/212?src=pr&el=footer). Last update [dcbd967...7b3334e](https://codecov.io/gh/apache/dubbo-go/pull/212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/212 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #212: update
version and fix bug
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
the title is improper. it should be "Fix: issue xxx"
[ Full content available at: https://github.com/apache/dubbo-go/pull/212 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org