You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/09/12 01:56:39 UTC
[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6010: [Clean up] Separate TextIndex from InvertedIndex
Jackie-Jiang opened a new pull request #6010:
URL: https://github.com/apache/incubator-pinot/pull/6010
## Description
Introduce `TextIndexCreator` and `TextIndexReader` for text index
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6010: [Clean up] Separate TextIndex from InvertedIndex
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #6010:
URL: https://github.com/apache/incubator-pinot/pull/6010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6010: [Clean up] Separate TextIndex from InvertedIndex
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #6010:
URL: https://github.com/apache/incubator-pinot/pull/6010#discussion_r490504285
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/column/ColumnIndexContainer.java
##########
@@ -42,14 +43,14 @@
InvertedIndexReader<?> getInvertedIndex();
/**
- * Returns the inverted index for the column, or {@code null} if it does not exist.
+ * Returns the range index for the column, or {@code null} if it does not exist.
Review comment:
Are we planning to do similar cleanup for range index as well? It is also based off InvertedIndex (for the same reasons why TextIndex was based)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6010: [Clean up] Separate TextIndex from InvertedIndex
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #6010:
URL: https://github.com/apache/incubator-pinot/pull/6010#discussion_r490525042
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/column/ColumnIndexContainer.java
##########
@@ -42,14 +43,14 @@
InvertedIndexReader<?> getInvertedIndex();
/**
- * Returns the inverted index for the column, or {@code null} if it does not exist.
+ * Returns the range index for the column, or {@code null} if it does not exist.
Review comment:
Yes, will do that in a separate PR. We need to design the interface for the range index
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org