[GitHub] [flink] fredia commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

["fredia (via GitHub)" <gi...@apache.org>]

fredia commented on code in PR #21822:
URL: https://github.com/apache/flink/pull/21822#discussion_r1170776506


##########
flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/FsStateChangelogWriterTest.java:
##########
@@ -246,15 +248,233 @@ void testFileAvailableAfterClose() throws Exception {
         }
     }
 
+    @Test
+    void testLocalFileDiscard() throws Exception {

Review Comment:
   Thanks for the comments, as @zoltar9264 mentioned, this UT is used to verify that the newly changed code can correctly delete the local file. It doesn't have a bad effect on current code, I tend to keep it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org