[GitHub] [iceberg] rdblue commented on a change in pull request #1836: Core: Add data and delete writers in FileAppenderFactory.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1836:
URL: https://github.com/apache/iceberg/pull/1836#discussion_r533731795



##########
File path: data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java
##########
@@ -95,4 +115,88 @@ public GenericAppenderFactory setAll(Map<String, String> properties) {
       throw new UncheckedIOException(e);
     }
   }
+
+  @Override
+  public org.apache.iceberg.io.DataWriter<Record> newDataWriter(EncryptedOutputFile file, FileFormat format,
+                                                                StructLike partition) {
+    return new org.apache.iceberg.io.DataWriter<>(
+        newAppender(file.encryptingOutputFile(), format), format,
+        file.encryptingOutputFile().location(), spec, partition, file.keyMetadata());
+  }

Review comment:
       Sounds good, thanks for explaining it to me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org