[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5674: Pinot fs bug fix

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452321071



##########
File path: pinot-spi/src/test/java/org/apache/pinot/spi/env/PinotConfigurationTest.java
##########
@@ -24,24 +24,116 @@
 import java.nio.file.Files;
 import java.nio.file.Paths;
 import java.nio.file.StandardCopyOption;
+import java.util.Arrays;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
+import org.apache.commons.configuration.ConfigurationException;
+import org.apache.commons.configuration.PropertiesConfiguration;
+import org.apache.pinot.spi.ingestion.batch.spec.PinotFSSpec;
 import org.testng.Assert;
 import org.testng.annotations.Test;
 
 
 public class PinotConfigurationTest {
+
+  @Test
+  public void assertBaseOperations() {

Review comment:
       Thanks for adding these unit tests. Wondering if we can also exercise the various code paths that perform different subsettings (eg for PinotFS, Crypter, Server, etc) with tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org