You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2019/10/31 01:45:21 UTC

[hbase] branch master updated: HBASE-23231 Addendum remove redundant metrics.clear in ReplicationSource

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new 2451c2c  HBASE-23231 Addendum remove redundant metrics.clear in ReplicationSource
2451c2c is described below

commit 2451c2c532e70766f8f1a045a1e3573dfebb8688
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Thu Oct 31 09:40:39 2019 +0800

    HBASE-23231 Addendum remove redundant metrics.clear in ReplicationSource
    
    This is only a problem on master which was introduced when we merge sync replication feature branch back
---
 .../hadoop/hbase/replication/regionserver/ReplicationSource.java       | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
index 78edffa..683a9ab 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
@@ -600,9 +600,6 @@ public class ReplicationSource implements ReplicationSourceInterface {
     if (this.replicationEndpoint != null) {
       this.replicationEndpoint.stop();
     }
-    if (clearMetrics) {
-      metrics.clear();
-    }
     if (join) {
       for (ReplicationSourceShipper worker : workers) {
         Threads.shutdown(worker, this.sleepForRetries);