You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2023/04/27 10:16:45 UTC
[GitHub] [doris] starocean999 opened a new pull request, #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
starocean999 opened a new pull request, #19169:
URL: https://github.com/apache/doris/pull/19169
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #19169:
URL: https://github.com/apache/doris/pull/19169#issuecomment-1525379967
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19169:
URL: https://github.com/apache/doris/pull/19169#issuecomment-1525574718
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #19169:
URL: https://github.com/apache/doris/pull/19169#issuecomment-1525395332
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #19169:
URL: https://github.com/apache/doris/pull/19169#discussion_r1179403665
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1357,8 +1357,8 @@ private void computeFragmentExecParams() throws Exception {
// when left table is empty, it's bucketset is empty.
// set right table destination address to the address of left table
- if (destParams.instanceExecParams.size() == 1
- && destParams.instanceExecParams.get(0).bucketSeqSet.isEmpty()) {
+ if (destParams.instanceExecParams.size() == 1 && (bucketNum == 0
+ || destParams.instanceExecParams.get(0).bucketSeqSet.isEmpty())) {
Review Comment:
why add back `destParams.instanceExecParams.get(0).bucketSeqSet.isEmpty()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19169:
URL: https://github.com/apache/doris/pull/19169#issuecomment-1525542704
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.04 seconds
stream load tsv: 427 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230427114015_clickbench_pr_136529.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #19169:
URL: https://github.com/apache/doris/pull/19169#issuecomment-1525806276
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on a diff in pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on code in PR #19169:
URL: https://github.com/apache/doris/pull/19169#discussion_r1179848673
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1357,8 +1357,8 @@ private void computeFragmentExecParams() throws Exception {
// when left table is empty, it's bucketset is empty.
// set right table destination address to the address of left table
- if (destParams.instanceExecParams.size() == 1
- && destParams.instanceExecParams.get(0).bucketSeqSet.isEmpty()) {
+ if (destParams.instanceExecParams.size() == 1 && (bucketNum == 0
+ || destParams.instanceExecParams.get(0).bucketSeqSet.isEmpty())) {
Review Comment:
for colocate join, the bucketNum is the bucket number in default distribution info. So even the table is empty, the bucketNum is not 0. So add it back to handle the colocate join case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19169:
URL: https://github.com/apache/doris/pull/19169#issuecomment-1525574784
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 merged pull request #19169: [fix](fe)fix bug if left table is empty and there are multiple right tables need do bucket shuffle to left side
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #19169:
URL: https://github.com/apache/doris/pull/19169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org