You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "zinal (via GitHub)" <gi...@apache.org> on 2023/02/28 16:18:22 UTC
[GitHub] [airflow] zinal opened a new pull request, #29811: Add support for Yandex Dataproc cluster labels
zinal opened a new pull request, #29811:
URL: https://github.com/apache/airflow/pull/29811
Yandex Dataproc supports labels on its cluster resources to distinguish various projects and teams.
This commit adds support for specifying labels during cluster creation in the `DataprocCreateClusterOperator`, as part of the `yandex` provider.
`yandexcloud` provider dependency has to be updated to version 202, to support the labels function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1556739612
I'm closing this PR since the provider is suspended.
Should the protobuf issue with yandex package is resolved we can reopen this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1454838524
Rebased to rebuild with latest main/ account for failed job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1689898553
Seems there was some accidental cancelling of post cache. All looks good. Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1516084489
FYI, Yandex provider has been suspended from releases and we are not accepting any new PRS for yandex until the problem with protobuf is solved by Yandex maintainer. See #30667 - the issue to be solved is here and Yandex maintainers will have to resume the provider after the problem is fixed https://github.com/yandex-cloud/python-sdk/issues/71
More information about suspending providers in https://github.com/apache/airflow/blob/main/airflow/providers/SUSPENDING_AND_RESUMING_PROVIDERS.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zinal commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "zinal (via GitHub)" <gi...@apache.org>.
zinal commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1689413657
To my understanding, the provider is no longer suspended, as the protobuf4 support has been implemented in its dependencies.
Can you please re-open this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1448466825
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1689898722
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed pull request #29811: Add support for Yandex Dataproc cluster labels
URL: https://github.com/apache/airflow/pull/29811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1689860605
Yes. Should be fine to merge it now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29811:
URL: https://github.com/apache/airflow/pull/29811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1513935293
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #29811: Add support for Yandex Dataproc cluster labels
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #29811:
URL: https://github.com/apache/airflow/pull/29811#issuecomment-1454848852
Please [install and run pre-commits](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst) it will handle the static checks failure for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org