[GitHub] [airflow] Khrol commented on issue #5949: [AIRFLOW-5343] Add pool_pre_ping to SQLAlchemy

[GitBox <gi...@apache.org>]

Khrol commented on issue #5949: [AIRFLOW-5343] Add pool_pre_ping to SQLAlchemy
URL: https://github.com/apache/airflow/pull/5949#issuecomment-527841440
 
 
   > What difference in performance/behaviour does enabling this btw? When might a user want it on or not?
   
   ```
   The approach adds a small bit of overhead to the connection checkout process, however is otherwise the most simple and reliable approach to completely eliminating database errors due to stale pooled connections.
   ```
   
   Connection to Airflow backend should not be a bottleneck in Airflow performance. Meanwhile, we are observing flakiness there in our local infrastructure so such overhead might be a good tradeoff.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services