[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed

[GitBox <gi...@apache.org>]

Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844223314


##########
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##########
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
             }
         }
     }
-    
+
+    @Test
+    public void testRandomJUnit4PrintSeed()
+    {
+        long seed = 0L;
+        OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+        validator.verifyTextInLog( "To reproduce ordering use flag" );
+        validator = executeWithRandomOrder( "junit4" );
+        validator.verifyTextInLog( "To reproduce ordering use flag" );

Review Comment:
   Hi @delanym . Nice to meet you after the release Vote!
   I know that it is a matter of taste but these names of classes and methods determine the length of folders on the file system in our CI. Using `WithSeed` and `WithoutSeed` is shorter.
   Now, I have realized that @delanym is using two executions which might be utilized in some way.
   @delanym what wat your point? You wanted to compare the XML reports and the order of tests? Something else? If you want to make sure that the seed is set, such situation can be verified with the old IT where a debug message can be printed in the logs and the IT can check that the message was printed with seed != NULL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org