You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2020/10/20 06:19:40 UTC

[GitHub] [wicket] ams-tschoening commented on a change in pull request #457: WICKET-6823: Add a container to AbstractTransformerBehavior to support multiple instances per component.

ams-tschoening commented on a change in pull request #457:
URL: https://github.com/apache/wicket/pull/457#discussion_r508235530



##########
File path: wicket-core/src/main/java/org/apache/wicket/markup/transformer/AbstractTransformerBehavior.java
##########
@@ -26,17 +31,114 @@
 import org.apache.wicket.request.http.WebResponse;
 
 /**
- * A {@link Behavior} which can be added to any component. It allows to post-process (transform) the
+ * A {@link Behavior} which can be added to any component, allowing to post-process (transform) the
  * markup generated by the component.
- * 
+ * <p>
+ * There's one important limitation with the current implementation: Multiple different instances of

Review comment:
       I disagree, `AbstractTransformerBehavior` itself keeps the limitation and especially existing users should be made aware. The container is only one possible workaround/solution, a different `AbstractTransformerBehavior` itself would be another one. With that the sentence could be removed, but with the container only the sentence still applies.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org