[GitHub] [arrow-datafusion] waitingkuo commented on a diff in pull request #4054: Implement `current_time` scalar function

[GitBox <gi...@apache.org>]

waitingkuo commented on code in PR #4054:
URL: https://github.com/apache/arrow-datafusion/pull/4054#discussion_r1010176627


##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -433,6 +433,12 @@ pub fn create_physical_fun(
                 execution_props.query_execution_start_time,
             ))
         }
+        BuiltinScalarFunction::CurrentTime => {
+            // bind value for current_time at plan time
+            Arc::new(datetime_expressions::make_current_time(
+                execution_props.query_execution_start_time,
+            ))

Review Comment:
   👍 
   
   @mingmwang all the current_time within a query uses the same query_execution_start_time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org