You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/15 08:53:28 UTC
[GitHub] [rocketmq-mqtt] tianliuliu opened a new pull request #34: [ISSUE #33] some thread safety problems
tianliuliu opened a new pull request #34:
URL: https://github.com/apache/rocketmq-mqtt/pull/34
fix #33 fix some thread safety problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing merged pull request #34: [ISSUE #33] some thread safety problems
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #34:
URL: https://github.com/apache/rocketmq-mqtt/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #34: [ISSUE #33] some thread safety problems
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #34:
URL: https://github.com/apache/rocketmq-mqtt/pull/34#issuecomment-1067721850
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#34](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (231a7cb) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/da74925fcc733d3f18cd7cdd41d390256bd462bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da74925) will **decrease** coverage by `0.02%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 21.59% 21.57% -0.03%
==========================================
Files 87 87
Lines 3713 3717 +4
Branches 607 609 +2
==========================================
Hits 802 802
- Misses 2696 2698 +2
- Partials 215 217 +2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/rocketmq/mqtt/cs/session/infly/RetryDriver.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL2luZmx5L1JldHJ5RHJpdmVyLmphdmE=) | `40.11% <33.33%> (-0.48%)` | :arrow_down: |
| [.../apache/rocketmq/mqtt/ds/notify/NotifyManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9ub3RpZnkvTm90aWZ5TWFuYWdlci5qYXZh) | `25.53% <33.33%> (-0.37%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [da74925...231a7cb](https://codecov.io/gh/apache/rocketmq-mqtt/pull/34?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org