You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/04/28 10:01:24 UTC

[GitHub] [kylin] zhangayqian commented on a change in pull request #1187: KYLIN-4470 The user cannot log in kylin normally after being assigned…

zhangayqian commented on a change in pull request #1187:
URL: https://github.com/apache/kylin/pull/1187#discussion_r416488280



##########
File path: server-base/src/main/java/org/apache/kylin/rest/controller/UserController.java
##########
@@ -191,6 +191,8 @@ public ManagedUser save(@PathVariable("userName") String userName, @RequestBody
         }
         logger.info("Saving {}", user);
 
+        user.setPassword(pwdEncode(user.getPassword()));

Review comment:
       Debugging found that the password of the ‘user’ passed in by this method is not encoded. If the password is directly updated to the metadata, the authentication of the user name and password will fail  for bad credential.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org