You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2025/04/03 17:35:55 UTC
[PR] Bump dependencies where possible and fix related issues [accumulo]
dlmarion opened a new pull request, #5450:
URL: https://github.com/apache/accumulo/pull/5450
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump dependencies where possible and fix related issues [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5450:
URL: https://github.com/apache/accumulo/pull/5450#issuecomment-2776500554
I wasn't able to bump errorprone to 2.36 or 2.37 as maven-compiler-plugin fails to compile the source but doesn't present the error. I haven't been able to figure out why yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump dependencies where possible and fix related issues [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5450:
URL: https://github.com/apache/accumulo/pull/5450#issuecomment-2776753604
> Most of this looks okay. Did you check each changed dependency for any LICENSE/NOTICE changes?
I didn't, but I can do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump dependencies where possible and fix related issues [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #5450:
URL: https://github.com/apache/accumulo/pull/5450#discussion_r2027493727
##########
server/manager/src/main/java/org/apache/accumulo/manager/state/SetGoalState.java:
##########
@@ -36,7 +36,15 @@ public class SetGoalState {
* Utility program that will change the goal state for the manager from the command line.
*/
public static void main(String[] args) throws Exception {
- if (args.length != 1 || ManagerGoalState.valueOf(args[0]) == null) {
+ if (args.length != 1) {
+ System.err.println(
+ "Usage: accumulo " + SetGoalState.class.getName() + " [NORMAL|SAFE_MODE|CLEAN_STOP]");
+ System.exit(-1);
+ }
+
+ try {
+ ManagerGoalState.valueOf(args[0]);
Review Comment:
updated errorprone flagged this is an impossible null check because Enum.valueOf does not return null, it throws an IllegalArgumentException.
##########
minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java:
##########
@@ -150,7 +149,7 @@ public void adminStopAll() throws IOException {
*/
public void setGoalState(String goalState) throws IOException {
requireNonNull(goalState, "Goal state must not be null");
- checkArgument(ManagerGoalState.valueOf(goalState) != null, "Unknown goal state: " + goalState);
+ ManagerGoalState.valueOf(goalState);
Review Comment:
updated errorprone flagged this is an impossible null check because Enum.valueOf does not return null, it throws an IllegalArgumentException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump dependencies where possible and fix related issues [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5450:
URL: https://github.com/apache/accumulo/pull/5450#issuecomment-2776799173
> > Most of this looks okay. Did you check each changed dependency for any LICENSE/NOTICE changes?
>
> I didn't, but I can do that
I looked and didn't find any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump dependencies where possible and fix related issues [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #5450:
URL: https://github.com/apache/accumulo/pull/5450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump dependencies where possible and fix related issues [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #5450:
URL: https://github.com/apache/accumulo/pull/5450#discussion_r2027619784
##########
server/manager/src/main/java/org/apache/accumulo/manager/state/SetGoalState.java:
##########
@@ -36,7 +36,15 @@ public class SetGoalState {
* Utility program that will change the goal state for the manager from the command line.
*/
public static void main(String[] args) throws Exception {
- if (args.length != 1 || ManagerGoalState.valueOf(args[0]) == null) {
+ if (args.length != 1) {
+ System.err.println(
+ "Usage: accumulo " + SetGoalState.class.getName() + " [NORMAL|SAFE_MODE|CLEAN_STOP]");
+ System.exit(-1);
+ }
+
+ try {
Review Comment:
Change is bugged, should be `Preconditions.checkArgument(args.length == 1);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump dependencies where possible and fix related issues [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #5450:
URL: https://github.com/apache/accumulo/pull/5450#discussion_r2027549879
##########
pom.xml:
##########
@@ -412,12 +412,12 @@
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-collections4</artifactId>
- <version>4.4</version>
+ <version>4.5.0-M3</version>
Review Comment:
`-M3` indicates a prerelease milestone version, not a final version, and should be avoided. The last final version should be used instead, which I think is still 4.4
##########
server/manager/src/main/java/org/apache/accumulo/manager/state/SetGoalState.java:
##########
@@ -36,7 +36,15 @@ public class SetGoalState {
* Utility program that will change the goal state for the manager from the command line.
*/
public static void main(String[] args) throws Exception {
- if (args.length != 1 || ManagerGoalState.valueOf(args[0]) == null) {
+ if (args.length != 1) {
+ System.err.println(
+ "Usage: accumulo " + SetGoalState.class.getName() + " [NORMAL|SAFE_MODE|CLEAN_STOP]");
+ System.exit(-1);
+ }
+
+ try {
Review Comment:
```suggestion
try {
Preconditions.checkArgument(args.length != 1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org