You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2015/11/06 16:26:13 UTC
[GitHub] flink pull request: [FLINK-2979] Fix RollingSink truncate for Hado...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1336
[FLINK-2979] Fix RollingSink truncate for Hadoop 2.7
The problem was, that truncate is asynchronous and the RollingSink was
not taking this into account.
Now it has a loop after the truncate call that waits until the file is
actually truncated.
This also changes the Hadoop 2.6 travis build to 2.7, instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink rolling-sink-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1336
----
commit 05136da77617a577e62cca2dec469e2c2d14b91e
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2015-11-06T15:15:06Z
[FLINK-2979] Fix RollingSink truncate for Hadoop 2.7
The problem was, that truncate is asynchronous and the RollingSink was
not taking this into account.
Now it has a loop after the truncate call that waits until the file is
actually truncated.
This also changes the Hadoop 2.6 travis build to 2.7, instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2979] Fix RollingSink truncate for Hado...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1336#issuecomment-154499798
Can you also merge this into the 0.10 branch, so the 0.10.1 release will get the fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2979] Fix RollingSink truncate for Hado...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2979] Fix RollingSink truncate for Hado...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1336#issuecomment-154499240
Manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2979] Fix RollingSink truncate for Hado...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1336#issuecomment-154499953
Already done. :smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---