You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by gi...@git.apache.org on 2017/07/26 17:24:50 UTC
[GitHub] sijie commented on a change in pull request #298: Issue 295: LocalBookKeeper fails to start up
sijie commented on a change in pull request #298: Issue 295: LocalBookKeeper fails to start up
URL: https://github.com/apache/bookkeeper/pull/298#discussion_r129640013
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
##########
@@ -299,6 +297,9 @@ static void startLocalBookiesInternal(ServerConfiguration conf,
}
throw ie;
}
+ } catch (Exception e) {
Review comment:
+1 on this. if we want logging, we should re-throw it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services