You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/11/24 10:36:54 UTC

[isis] branch master updated: ISIS-2877: enable ValueTypeExampleJodaDateTime

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new e3da2c4  ISIS-2877: enable ValueTypeExampleJodaDateTime
e3da2c4 is described below

commit e3da2c41107ba298e48d658a2993916c27676c3e
Author: Andi Huber <ah...@apache.org>
AuthorDate: Wed Nov 24 11:35:04 2021 +0100

    ISIS-2877: enable ValueTypeExampleJodaDateTime
    
    - so can troubleshoot CI build
---
 .../apache/isis/testdomain/model/valuetypes/ValueTypeExample.java | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/regressiontests/stable/src/main/java/org/apache/isis/testdomain/model/valuetypes/ValueTypeExample.java b/regressiontests/stable/src/main/java/org/apache/isis/testdomain/model/valuetypes/ValueTypeExample.java
index 1ef3a36..2ab3ed8 100644
--- a/regressiontests/stable/src/main/java/org/apache/isis/testdomain/model/valuetypes/ValueTypeExample.java
+++ b/regressiontests/stable/src/main/java/org/apache/isis/testdomain/model/valuetypes/ValueTypeExample.java
@@ -383,7 +383,6 @@ public abstract class ValueTypeExample<T> {
         private LocalTime updateValue = LocalTime.now().plusSeconds(15);
     }
 
-  //TODO    OffsetDateTime - fails because format with time-zone fails on CI
     @DomainObject(
             logicalTypeName = "isis.testdomain.valuetypes.ValueTypeExampleOffsetDateTime",
             nature = Nature.BEAN)
@@ -395,7 +394,6 @@ public abstract class ValueTypeExample<T> {
         private OffsetDateTime updateValue = OffsetDateTime.now().plusDays(2).plusSeconds(15);
     }
 
-  //TODO    OffsetTime - fails because format with time-zone fails on CI
     @DomainObject(
             logicalTypeName = "isis.testdomain.valuetypes.ValueTypeExampleOffsetTime",
             nature = Nature.BEAN)
@@ -420,9 +418,9 @@ public abstract class ValueTypeExample<T> {
     // -- EXAMPLES - TEMPORAL - JODA TIME
 
   //TODO    org.joda.time.DateTime - fails because format with time-zone fails on CI
-//    @DomainObject(
-//            logicalTypeName = "isis.testdomain.valuetypes.ValueTypeExampleJodaDateTime",
-//            nature = Nature.BEAN)
+    @DomainObject(
+            logicalTypeName = "isis.testdomain.valuetypes.ValueTypeExampleJodaDateTime",
+            nature = Nature.BEAN)
     public static class ValueTypeExampleJodaDateTime
     extends ValueTypeExample<org.joda.time.DateTime> {
         @Property @Getter @Setter