You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2023/02/09 14:22:07 UTC

[GitHub] [doris] morrySnow commented on a diff in pull request #16549: (fix)[multi-catalog][nereids] Reset ExternalFileScanNode required slots after Nereids planner do projection.

morrySnow commented on code in PR #16549:
URL: https://github.com/apache/doris/pull/16549#discussion_r1101528992


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1126,6 +1127,13 @@ private void updateChildSlotsMaterialization(PlanNode execPlan,
             context.getDescTable()
                     .getTupleDesc(execPlan.getTupleIds().get(0)).getSlots().get(0).setIsMaterialized(true);
         }
+        if (execPlan instanceof ScanNode) {
+            try {
+                ((ScanNode) execPlan).updateRequiredSlots();
+            } catch (UserException e) {
+                LOG.warn("User Exception while reset external file scan node contexts.", e);

Review Comment:
   throw a runtime exception to avoid execute a wrong plan on BE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org