You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by jolynch <gi...@git.apache.org> on 2018/11/07 21:20:17 UTC

[GitHub] cassandra pull request #212: Rework the wait for healthy logic to count down...

Github user jolynch commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/212#discussion_r231680735
  
    --- Diff: src/java/org/apache/cassandra/config/Config.java ---
    @@ -380,9 +380,23 @@
         public RepairCommandPoolFullStrategy repair_command_pool_full_strategy = RepairCommandPoolFullStrategy.queue;
         public int repair_command_pool_size = concurrent_validations;
     
    -    // parameters to adjust how much to delay startup until a certain amount of the cluster is connect to and marked alive
    -    public int block_for_peers_percentage = 70;
    +    /**
    +     * When a node first starts up it intially considers all other peers as DOWN, and then as the initial gossip
    +     * broadcast messages comes back nodes transition to UP. These options configure how long we wait for peers to
    +     * connect before we make this node available as a coordinator. Furthermore, if this feature is enabled
    +     * (timeout >= 0) Cassandra initiates the non gossip channel internode connections on startup as well and waits
    --- End diff --
    
    Ok, I reworded it. I think that having an escape hatch makes sense, what do you think? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org