You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2017/10/09 14:19:17 UTC

[discuss][git] Repository names cannot contain dots

Hi,

Well, word came back from infra that we can't use dots in the
repository names [1]. I asked about the reasoning for that but did not
yet get an answer.

The question is - what do we do now? Do we want to replace dots with
something else and live with a discrepancy between artifact ids and
repository names? Do we wait until we have better solution?

Thanks,

Robert


[1]: https://issues.apache.org/jira/browse/INFRA-15229?focusedCommentId
=16197034&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
tabpanel#comment-16197034

Re: [discuss][git] Repository names cannot contain dots

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Monday 09 October 2017 17:49:52 Robert Munteanu wrote:
> On Mon, 2017-10-09 at 14:25 +0000, Stefan Seifert wrote:
> > if the git repo names are still based on artifact id with only "."
> > replaced by "-" i suppose this would be ok from my side.
> > we mainly wanted to avoid to choose completely different naming
> > schema which may be hard to guess if you have only the artifact id of
> > a given bundle.
> 
> Right. Infra indicates that they can't support dots in repostiory
> 
> names:
> > On our side, since we don't have any repos with periods, the overhead
> 
> for making sure it won't break things is a bit prohibitive.So for the
> time being I don't think we can allow it.
> 
> This is from the hipchat room, don't know if there are any archives
> available for it, pasting it here for completeness.
> 
> So it seems that we need to replace the dot with something. The dash (
> '-' ) is a good option, unless someone else things otherwise I'm going
> to go with the dash name.
> 
> E.g. instead of sling-org.apache.sling.api we'd have sling-org-apache-
> sling-api .

+1

O.

> Thanks,
> 
> Robert

Re: [discuss][git] Repository names cannot contain dots

Posted by Julian Sedding <js...@gmail.com>.
On Mon, Oct 9, 2017 at 4:55 PM, Robert Munteanu <ro...@apache.org> wrote:
> On Mon, 2017-10-09 at 14:54 +0000, Stefan Seifert wrote:
>> > E.g. instead of sling-org.apache.sling.api we'd have sling-org-
>> > apache-sling-api .
>>
>> reading this we might also decide to omit the "org-apache-sling" part
>> in here. otherwise all and every repo would start with "sling-org-
>> apache-sling-".
>> and it's still a clear rule.
>
> We have some repos which don't follow that convention
>
> - Maven toooling ( artifactId does not start with org.apache.sling )
> - Various tools and scripts ( migrated as sling-tooling-scm and sling-
> tooling-jenkins )
> - Samples ( sling-samples )
>
> So maybe it would be simpler to keep the artifactId where dots are
> replaced by dashes.

Not terribly pretty, as Stefan pointed out, but pragmatically simple.

+1 for replacing dots with slashes

Regards
Julian

>
> Robert
>

RE: [discuss][git] Repository names cannot contain dots

Posted by Stefan Seifert <ss...@pro-vision.de>.
>We have some repos which don't follow that convention
>
>- Maven toooling ( artifactId does not start with org.apache.sling )
>- Various tools and scripts ( migrated as sling-tooling-scm and sling-
>tooling-jenkins )
>- Samples ( sling-samples )
>
>So maybe it would be simpler to keep the artifactId where dots are
>replaced by dashes.

ok

Re: [discuss][git] Repository names cannot contain dots

Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2017-10-09 at 14:54 +0000, Stefan Seifert wrote:
> > E.g. instead of sling-org.apache.sling.api we'd have sling-org-
> > apache-sling-api .
> 
> reading this we might also decide to omit the "org-apache-sling" part
> in here. otherwise all and every repo would start with "sling-org-
> apache-sling-".
> and it's still a clear rule.

We have some repos which don't follow that convention

- Maven toooling ( artifactId does not start with org.apache.sling )
- Various tools and scripts ( migrated as sling-tooling-scm and sling-
tooling-jenkins )
- Samples ( sling-samples )

So maybe it would be simpler to keep the artifactId where dots are
replaced by dashes.

Robert

RE: [discuss][git] Repository names cannot contain dots

Posted by Stefan Seifert <ss...@pro-vision.de>.
>E.g. instead of sling-org.apache.sling.api we'd have sling-org-apache-sling-api .

reading this we might also decide to omit the "org-apache-sling" part in here. otherwise all and every repo would start with "sling-org-apache-sling-".
and it's still a clear rule.

stefan

Re: [discuss][git] Repository names cannot contain dots

Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2017-10-09 at 14:25 +0000, Stefan Seifert wrote:
> if the git repo names are still based on artifact id with only "."
> replaced by "-" i suppose this would be ok from my side.
> we mainly wanted to avoid to choose completely different naming
> schema which may be hard to guess if you have only the artifact id of
> a given bundle.

Right. Infra indicates that they can't support dots in repostiory
names:

> On our side, since we don't have any repos with periods, the overhead
for making sure it won't break things is a bit prohibitive.So for the
time being I don't think we can allow it.

This is from the hipchat room, don't know if there are any archives
available for it, pasting it here for completeness.

So it seems that we need to replace the dot with something. The dash (
'-' ) is a good option, unless someone else things otherwise I'm going
to go with the dash name.

E.g. instead of sling-org.apache.sling.api we'd have sling-org-apache-
sling-api .

Thanks,

Robert

Re: [discuss][git] Repository names cannot contain dots

Posted by Konrad Windszus <ko...@gmx.de>.
No one will ever manually type the clone URLs but always copy from some web page or use the repo manifest. Therefore having it close to the artifact id is good enough. I am fine as well with replacing "." by "-" in the artifact id.
Konrad

> On 9. Oct 2017, at 16:25, Stefan Seifert <ss...@pro-vision.de> wrote:
> 
> if the git repo names are still based on artifact id with only "." replaced by "-" i suppose this would be ok from my side.
> we mainly wanted to avoid to choose completely different naming schema which may be hard to guess if you have only the artifact id of a given bundle.
> 
> stefan
> 
>> -----Original Message-----
>> From: Robert Munteanu [mailto:rombert@apache.org]
>> Sent: Monday, October 9, 2017 4:19 PM
>> To: dev@sling.apache.org
>> Subject: [discuss][git] Repository names cannot contain dots
>> 
>> Hi,
>> 
>> Well, word came back from infra that we can't use dots in the
>> repository names [1]. I asked about the reasoning for that but did not
>> yet get an answer.
>> 
>> The question is - what do we do now? Do we want to replace dots with
>> something else and live with a discrepancy between artifact ids and
>> repository names? Do we wait until we have better solution?
>> 
>> Thanks,
>> 
>> Robert
>> 
>> 
>> [1]: https://issues.apache.org/jira/browse/INFRA-15229?focusedCommentId
>> =16197034&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
>> tabpanel#comment-16197034
>

RE: [discuss][git] Repository names cannot contain dots

Posted by Stefan Seifert <ss...@pro-vision.de>.
if the git repo names are still based on artifact id with only "." replaced by "-" i suppose this would be ok from my side.
we mainly wanted to avoid to choose completely different naming schema which may be hard to guess if you have only the artifact id of a given bundle.

stefan

>-----Original Message-----
>From: Robert Munteanu [mailto:rombert@apache.org]
>Sent: Monday, October 9, 2017 4:19 PM
>To: dev@sling.apache.org
>Subject: [discuss][git] Repository names cannot contain dots
>
>Hi,
>
>Well, word came back from infra that we can't use dots in the
>repository names [1]. I asked about the reasoning for that but did not
>yet get an answer.
>
>The question is - what do we do now? Do we want to replace dots with
>something else and live with a discrepancy between artifact ids and
>repository names? Do we wait until we have better solution?
>
>Thanks,
>
>Robert
>
>
>[1]: https://issues.apache.org/jira/browse/INFRA-15229?focusedCommentId
>=16197034&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
>tabpanel#comment-16197034