[GitHub] sijie commented on a change in pull request #1008: BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1008: BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper
URL: https://github.com/apache/bookkeeper/pull/1008#discussion_r162275474
 
 

 ##########
 File path: site/bps/BP-25-MovingChecksumToProto.md
 ##########
 @@ -0,0 +1,27 @@
+---
+title: "BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper"
+issue: https://github.com/apache/bookkeeper/issues/1007
+state: "Under Discussion"
+release: "N/A"
+---
+
+### Motivation
+
+Current the checksum implementation is in client module while the checksum semantic is more close to protocol. Moreover, moving the checksum implementation to protocol will avoid server module's dependency to client module when doing checksum in server side.
+
+### Public Interfaces
+
+An internal refactor not affecting public interfaces.
+
+### Proposed Changes
+
+Move the DigestManager and related classes to proto module
 
 Review comment:
   which package are you thinking of "org.apache.bookkeeper.proto" or "org.apache.bookkeeper.proto.checksum"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services