You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/06/14 00:07:33 UTC
[GitHub] beam pull request #3355: [BEAM-1287] Add support for PipelineOptions paramet...
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3355
[BEAM-1287] Add support for PipelineOptions parameters
This is a step towards eliminating catch-all context parameters and
making DoFns express their fine-grained data needs.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
I'm letting this JIRA scope-creep to anything that helps clarify the parameters here. So this gives direct `PipelineOptions` access, and then we'll want direct `Element` access and `OutputReceiver` access and `WindowedOutputReceiver` access. If we jump right to the last one, we'll have redundant methods in the context and output receiver, which could be a smidge confusing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam PipelineOptionsParameter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3355
----
commit cf0951b983c29c26752f30270c5aa20e86505642
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-06-13T17:29:50Z
Add support for PipelineOptions parameters
This is a step towards eliminating catch-all context parameters and
making DoFns express their fine-grained data needs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #3355: [BEAM-1287] Add support for PipelineOptions paramet...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---