You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Disha Talreja via Review Board <no...@reviews.apache.org> on 2021/10/07 23:50:44 UTC
Review Request 73637: ATLAS-4370: Persist Metrics for user to retrieve
Metrics info at a past timestamp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Sarath Subramanian, and Sidharth Mishra.
Bugs: ATLAS-4370
https://issues.apache.org/jira/browse/ATLAS-4370
Repository: atlas
Description
-------
Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
Diffs
-----
addons/models/0000-Area0/0010-base_model.json 769d8859f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 20f8f7343
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2febff469
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsBaseObject.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMinInfo.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java beb90e67b
repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 135b94b36
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java.orig PRE-CREATION
Diff: https://reviews.apache.org/r/73637/diff/1/
Testing
-------
1) Tested locally.
2) Patched a cluster.
Thanks,
Disha Talreja
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Radhika Kundam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/#review223719
-----------------------------------------------------------
Ship it!
Ship It!
- Radhika Kundam
On Nov. 9, 2021, 11:54 a.m., Disha Talreja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73637/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2021, 11:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4370
> https://issues.apache.org/jira/browse/ATLAS-4370
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
>
>
> Diffs
> -----
>
> addons/models/0000-Area0/0010-base_model.json 769d8859f
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7d092616d
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
> repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
> repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0580f7f33
>
>
> Diff: https://reviews.apache.org/r/73637/diff/6/
>
>
> Testing
> -------
>
> 1) Tested locally.
> 2) Patched a cluster.
>
> PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
>
>
> Thanks,
>
> Disha Talreja
>
>
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/#review223729
-----------------------------------------------------------
Fix it, then Ship it!
addons/models/0000-Area0/0010-base_model.json
Lines 416 (patched)
<https://reviews.apache.org/r/73637/#comment312829>
"__AtlasMetricsStat" type is duplicated. Please review.
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 428 (patched)
<https://reviews.apache.org/r/73637/#comment312830>
why add 4 debug log for entry/exit methods? Add a single entry and exit for main method:
At start:
LOG.debug("==> AdminResource.scheduleSaveAndDeleteMetrics()");
At End:
LOG.debug("<== AdminResource.scheduleSaveAndDeleteMetrics()");
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 453 (patched)
<https://reviews.apache.org/r/73637/#comment312831>
consider moving private methods after public
- Sarath Subramanian
On Nov. 9, 2021, 11:54 a.m., Disha Talreja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73637/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2021, 11:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4370
> https://issues.apache.org/jira/browse/ATLAS-4370
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
>
>
> Diffs
> -----
>
> addons/models/0000-Area0/0010-base_model.json 769d8859f
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7d092616d
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
> repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
> repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0580f7f33
>
>
> Diff: https://reviews.apache.org/r/73637/diff/6/
>
>
> Testing
> -------
>
> 1) Tested locally.
> 2) Patched a cluster.
>
> PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
>
>
> Thanks,
>
> Disha Talreja
>
>
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to retrieve Metrics info at a past timestamp
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/#review223793
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Nov. 15, 2021, 8:06 a.m., Disha Talreja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73637/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2021, 8:06 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4370
> https://issues.apache.org/jira/browse/ATLAS-4370
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
>
>
> Diffs
> -----
>
> addons/models/0000-Area0/0010-base_model.json 769d8859f
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7d092616d
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
> repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
> repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0580f7f33
>
>
> Diff: https://reviews.apache.org/r/73637/diff/7/
>
>
> Testing
> -------
>
> 1) Tested locally.
> 2) Patched a cluster.
>
> PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
>
>
> Thanks,
>
> Disha Talreja
>
>
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to retrieve Metrics info at a past timestamp
Posted by Disha Talreja via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/
-----------------------------------------------------------
(Updated Dec. 2, 2021, 5:36 p.m.)
Review request for atlas, Ashutosh Mestry, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra.
Bugs: ATLAS-4370
https://issues.apache.org/jira/browse/ATLAS-4370
Repository: atlas
Description
-------
Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
Diffs
-----
addons/models/0000-Area0/0010-base_model.json 769d8859f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7d092616d
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0580f7f33
Diff: https://reviews.apache.org/r/73637/diff/7/
Testing (updated)
-------
1) Tested locally.
2) Patched a cluster.
PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/997/console
Thanks,
Disha Talreja
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to retrieve Metrics info at a past timestamp
Posted by Disha Talreja via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/
-----------------------------------------------------------
(Updated Nov. 15, 2021, 4:06 p.m.)
Review request for atlas, Ashutosh Mestry, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra.
Changes
-------
1. Removed duplicate "__AtlasMetricsStat"
2. Single entry and exit debug logs in "scheduleSaveAndDeleteMetrics()"
3. Moved private methods after public
Bugs: ATLAS-4370
https://issues.apache.org/jira/browse/ATLAS-4370
Repository: atlas
Description
-------
Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
Diffs (updated)
-----
addons/models/0000-Area0/0010-base_model.json 769d8859f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7d092616d
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0580f7f33
Diff: https://reviews.apache.org/r/73637/diff/7/
Changes: https://reviews.apache.org/r/73637/diff/6-7/
Testing
-------
1) Tested locally.
2) Patched a cluster.
PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
Thanks,
Disha Talreja
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Disha Talreja via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/
-----------------------------------------------------------
(Updated Nov. 9, 2021, 7:54 p.m.)
Review request for atlas, Ashutosh Mestry, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra.
Bugs: ATLAS-4370
https://issues.apache.org/jira/browse/ATLAS-4370
Repository: atlas
Description
-------
Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
Diffs (updated)
-----
addons/models/0000-Area0/0010-base_model.json 769d8859f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7d092616d
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0580f7f33
Diff: https://reviews.apache.org/r/73637/diff/6/
Changes: https://reviews.apache.org/r/73637/diff/5-6/
Testing
-------
1) Tested locally.
2) Patched a cluster.
PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
Thanks,
Disha Talreja
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Disha Talreja via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/
-----------------------------------------------------------
(Updated Nov. 2, 2021, 8:35 p.m.)
Review request for atlas, Ashutosh Mestry, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra.
Changes
-------
Few changes based on review comments.
Bugs: ATLAS-4370
https://issues.apache.org/jira/browse/ATLAS-4370
Repository: atlas
Description
-------
Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
Diffs (updated)
-----
addons/models/0000-Area0/0010-base_model.json 769d8859f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7d092616d
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 135b94b36
Diff: https://reviews.apache.org/r/73637/diff/5/
Changes: https://reviews.apache.org/r/73637/diff/4-5/
Testing
-------
1) Tested locally.
2) Patched a cluster.
PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
Thanks,
Disha Talreja
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Disha Talreja via Review Board <no...@reviews.apache.org>.
> On Oct. 29, 2021, 7:09 p.m., Radhika Kundam wrote:
> > repository/src/main/java/org/apache/atlas/services/MetricsService.java
> > Lines 441 (patched)
> > <https://reviews.apache.org/r/73637/diff/4/?file=2254350#file2254350line442>
> >
> > Why do we need to map to AtlasMetricsStat as already allMetrics is List of AtlasMetricsStat
allMetrics is a list of AtlasMetricsStat but this method also includes 'typeNames' and it needs to be passed to the appropriate constructor.
> On Oct. 29, 2021, 7:09 p.m., Radhika Kundam wrote:
> > repository/src/main/java/org/apache/atlas/services/MetricsService.java
> > Lines 442 (patched)
> > <https://reviews.apache.org/r/73637/diff/4/?file=2254350#file2254350line443>
> >
> > Instead of getting entire metricstats and then setting metrics to null here you can send minInfo flas true at Line#436
I had done that before but setting minInfo to true in the beginning fails with a NPE because constructor makes the following call "AtlasEntityUtil.metricsToTypeData(metrics, listOfTypeNames, typeData)" and this requires metrics. Hence, had to get entire metricsstats and then set metrics to null.
- Disha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/#review223697
-----------------------------------------------------------
On Oct. 26, 2021, 10:49 p.m., Disha Talreja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73637/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2021, 10:49 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4370
> https://issues.apache.org/jira/browse/ATLAS-4370
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
>
>
> Diffs
> -----
>
> addons/models/0000-Area0/0010-base_model.json 769d8859f
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2febff469
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
> repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
> repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 135b94b36
>
>
> Diff: https://reviews.apache.org/r/73637/diff/4/
>
>
> Testing
> -------
>
> 1) Tested locally.
> 2) Patched a cluster.
>
> PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
>
>
> Thanks,
>
> Disha Talreja
>
>
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Radhika Kundam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/#review223697
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Line 42 (original), 51 (patched)
<https://reviews.apache.org/r/73637/#comment312805>
Please import only required util classes.
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 441 (patched)
<https://reviews.apache.org/r/73637/#comment312804>
Why do we need to map to AtlasMetricsStat as already allMetrics is List of AtlasMetricsStat
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 442 (patched)
<https://reviews.apache.org/r/73637/#comment312802>
Instead of getting entire metricstats and then setting metrics to null here you can send minInfo flas true at Line#436
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 471 (patched)
<https://reviews.apache.org/r/73637/#comment312806>
At multiple places AtlasMetricsStat taking only Metrics as input then AtlasMetricsStat(Metrics) constructor can be implemented instead of passing null for typeNames.
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 495 (patched)
<https://reviews.apache.org/r/73637/#comment312807>
getAllMetricsStats(minInfo) returns AtlasMetricsStat. Do we need to map again to cast each element.
- Radhika Kundam
On Oct. 26, 2021, 3:49 p.m., Disha Talreja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73637/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2021, 3:49 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4370
> https://issues.apache.org/jira/browse/ATLAS-4370
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
>
>
> Diffs
> -----
>
> addons/models/0000-Area0/0010-base_model.json 769d8859f
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2febff469
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
> repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
> repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 135b94b36
>
>
> Diff: https://reviews.apache.org/r/73637/diff/4/
>
>
> Testing
> -------
>
> 1) Tested locally.
> 2) Patched a cluster.
>
> PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
>
>
> Thanks,
>
> Disha Talreja
>
>
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Disha Talreja via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/
-----------------------------------------------------------
(Updated Oct. 26, 2021, 10:49 p.m.)
Review request for atlas, Ashutosh Mestry, Sarath Subramanian, and Sidharth Mishra.
Changes
-------
Rebased against the most recent changes.
Bugs: ATLAS-4370
https://issues.apache.org/jira/browse/ATLAS-4370
Repository: atlas
Description
-------
Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
Diffs (updated)
-----
addons/models/0000-Area0/0010-base_model.json 769d8859f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2febff469
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 135b94b36
Diff: https://reviews.apache.org/r/73637/diff/4/
Changes: https://reviews.apache.org/r/73637/diff/3-4/
Testing
-------
1) Tested locally.
2) Patched a cluster.
PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
Thanks,
Disha Talreja
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Disha Talreja via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/
-----------------------------------------------------------
(Updated Oct. 23, 2021, 6:20 a.m.)
Review request for atlas, Ashutosh Mestry, Sarath Subramanian, and Sidharth Mishra.
Changes
-------
1. Changes based on review comments
2. Merged AtlasMetricsBaseObject & AtlasMetricsMinInfo into AtlasMetricsStat class
Bugs: ATLAS-4370
https://issues.apache.org/jira/browse/ATLAS-4370
Repository: atlas
Description
-------
Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
Diffs (updated)
-----
addons/models/0000-Area0/0010-base_model.json 769d8859f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2febff469
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java beb90e67b
repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 135b94b36
Diff: https://reviews.apache.org/r/73637/diff/3/
Changes: https://reviews.apache.org/r/73637/diff/2-3/
Testing
-------
1) Tested locally.
2) Patched a cluster.
PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
Thanks,
Disha Talreja
Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to
retrieve Metrics info at a past timestamp
Posted by Radhika Kundam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73637/#review223613
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMinInfo.java
Lines 44 (patched)
<https://reviews.apache.org/r/73637/#comment312719>
AtlasMetricsMinInfo logic looks complicated and it can be restructured along with AtlasMetricsStat to make it simple.
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMinInfo.java
Lines 52 (patched)
<https://reviews.apache.org/r/73637/#comment312715>
AtlasMetricsMinInfo to handle single typeName is redundant as it can be handled using constructor at line#61 list of typenames. This constructor can be removed to avoid duplicated code.
intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMinInfo.java
Lines 74 (patched)
<https://reviews.apache.org/r/73637/#comment312716>
unused method
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 362 (patched)
<https://reviews.apache.org/r/73637/#comment312718>
Return type can be void
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 516 (patched)
<https://reviews.apache.org/r/73637/#comment312717>
Need null check for return value of getTypeData().
- Radhika Kundam
On Oct. 7, 2021, 4:50 p.m., Disha Talreja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73637/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2021, 4:50 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4370
> https://issues.apache.org/jira/browse/ATLAS-4370
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest master branch.
>
>
> Diffs
> -----
>
> addons/models/0000-Area0/0010-base_model.json 769d8859f
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 20f8f7343
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2febff469
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsBaseObject.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMinInfo.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550
> repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/services/MetricsService.java ceb252822
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java beb90e67b
> repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 040592184
> test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 135b94b36
>
>
> Diff: https://reviews.apache.org/r/73637/diff/2/
>
>
> Testing
> -------
>
> 1) Tested locally.
> 2) Patched a cluster.
>
> PC build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/
>
>
> Thanks,
>
> Disha Talreja
>
>