You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/25 12:35:17 UTC
[GitHub] [airflow] potiuk opened a new pull request #17208: Updates to FlaskAppBuilder 3.3.2+
potiuk opened a new pull request #17208:
URL: https://github.com/apache/airflow/pull/17208
There are some clarifications about using the authentication
via FlaskAppBuilder - the change implements minimum version of the
FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series
to be only authlib rather than flask-oauth.
Fixes: #16944 (this is the second, proper fix this time).
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17208:
URL: https://github.com/apache/airflow/pull/17208#issuecomment-887581268
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17208:
URL: https://github.com/apache/airflow/pull/17208#issuecomment-888436413
Ah.I have to fix this failure, to also run --eager upgrade for K8S tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #17208:
URL: https://github.com/apache/airflow/pull/17208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17208:
URL: https://github.com/apache/airflow/pull/17208#issuecomment-888442536
Eh! It's actually a bug! We are running helm tests against LATEST images from ghcr.io, not the ones from latest sources! Fix is coming!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #17208:
URL: https://github.com/apache/airflow/pull/17208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17208:
URL: https://github.com/apache/airflow/pull/17208#issuecomment-887969689
I was hoping this would get us to SQLAlchemy 1.4, but alas it is not to be 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17208:
URL: https://github.com/apache/airflow/pull/17208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17208:
URL: https://github.com/apache/airflow/pull/17208#issuecomment-887602104
REbuilding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17208:
URL: https://github.com/apache/airflow/pull/17208#issuecomment-888436413
Ah.I have to fix this failure, to ~also run --eager upgrade~ not use constraints for K8S tests in case of setup changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17208: Updates to FlaskAppBuilder 3.3.2+
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17208:
URL: https://github.com/apache/airflow/pull/17208#issuecomment-888442536
Eh! It's actually a bug! We are running helm tests against LATEST images from ghcr.io, not the ones from latest sources! Fix is coming~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org