You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Niklas Merz <ni...@apache.org> on 2020/06/02 18:31:12 UTC

[DISCUSS] InAppBrowser 4.0.0 major release

Hi all,

since cordova-ios 6.0 was released recently the inappbrowser plugin does not work properly because of the removal of UIWebView. I would suggest we do a plugin *release as soon as possible*.

Since we already merged some major changes (including the UIWebview removal) this will be a major release.

Does anyone have a reason to delay the release?

From my personal use of the plugin to pending PRs would be helpfull for this release, but they need reviews. I would not delay the release for them and proceed without merging them.
https://github.com/apache/cordova-plugin-inappbrowser/pull/688
https://github.com/apache/cordova-plugin-inappbrowser/pull/656

Any other outstanding patches to land?

If not, I will start the release tomorrow.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by julio cesar sanchez <jc...@gmail.com>.
As far as I know, the versions are the minimum required to work, not the
minimum supported by the plugin.

But yeah, ideally we could set all of them to recent versions to make sure
people don't use them in very old versions.

For the record, not all plugins have engines or some have but not for all
versions, and really don't know if they properly work.

El jue., 4 jun. 2020 a las 19:40, Chris Brody (<ch...@gmail.com>)
escribió:

> The whole motivation behind adding the minimum Cordova engine version, in
> the first place, seems to be here:
>
> https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L33
>
> It says "Needs cordova/urlutil".
>
> I think we do not specify the minimum Cordova engine version on most of the
> plugins, unfortunately don't have much time to check this right now.
>
> Whenever we do specify a minimum Cordova engine version, I would favor
> specifying a version that is not excessively old such as 6 or 7. This is
> analogous to the Node.js ecosystem where the node field in engines does
> actually specify the minimum Node version it can work with.
>
> But yes, definitely should not update with the current Cordova version.
>
> Yeah, probably not worth blocking a release. I wish I had more time to help
> with this kind of improvement.
>
>
> On Thu, Jun 4, 2020 at 1:20 PM Niklas Merz <ni...@apache.org> wrote:
>
> > Correct me if I am wrong, but I don't think we want to update the
> > dependency versions to the current ones. It's just another version we
> > have to track and update.
> >
> > I must say I don't really know what they are for and would love to learn
> > about that.
> >
> > The PR updates them to be consistent and working with a bare minimum
> > like said in the PR with code checks. These old version numbers don't
> > mean that these version have to be supported and compatible. If users
> > have I issues we always advise to use the latest versions of everything.
> >
> > IMHO this shouldn't block a release.
> >
> > Am 04.06.20 um 17:14 schrieb Chris Brody:
> > > I would favor updating the minimum Cordova requirement in both
> > package.json
> > > and plugin.xml, as I just commented in PR #685. I wish I would have
> seen
> > it
> > > before PR #685 was merged.
> > >
> > >
> > > On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz <ni...@apache.org>
> > wrote:
> > >
> > >> I merged two outstanding patches just now.
> > >>
> > >> If no reviews or concern come up, I will start the release in a few
> > hours.
> > >>
> > >> June 2, 2020 8:31 PM, "Niklas Merz" <ni...@apache.org> wrote:
> > >>
> > >>> Hi all,
> > >>>
> > >>> since cordova-ios 6.0 was released recently the inappbrowser plugin
> > does
> > >> not work properly because
> > >>> of the removal of UIWebView. I would suggest we do a plugin *release
> as
> > >> soon as possible*.
> > >>>
> > >>> Since we already merged some major changes (including the UIWebview
> > >> removal) this will be a major
> > >>> release.
> > >>>
> > >>> Does anyone have a reason to delay the release?
> > >>>
> > >>> From my personal use of the plugin to pending PRs would be helpfull
> for
> > >> this release, but they need
> > >>> reviews. I would not delay the release for them and proceed without
> > >> merging them.
> > >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/688
> > >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/656
> > >>>
> > >>> Any other outstanding patches to land?
> > >>>
> > >>> If not, I will start the release tomorrow.
> > >>>
> > >>> ---------------------------------------------------------------------
> > >>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >>> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>

Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by Chris Brody <ch...@gmail.com>.
The whole motivation behind adding the minimum Cordova engine version, in
the first place, seems to be here:
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L33

It says "Needs cordova/urlutil".

I think we do not specify the minimum Cordova engine version on most of the
plugins, unfortunately don't have much time to check this right now.

Whenever we do specify a minimum Cordova engine version, I would favor
specifying a version that is not excessively old such as 6 or 7. This is
analogous to the Node.js ecosystem where the node field in engines does
actually specify the minimum Node version it can work with.

But yes, definitely should not update with the current Cordova version.

Yeah, probably not worth blocking a release. I wish I had more time to help
with this kind of improvement.


On Thu, Jun 4, 2020 at 1:20 PM Niklas Merz <ni...@apache.org> wrote:

> Correct me if I am wrong, but I don't think we want to update the
> dependency versions to the current ones. It's just another version we
> have to track and update.
>
> I must say I don't really know what they are for and would love to learn
> about that.
>
> The PR updates them to be consistent and working with a bare minimum
> like said in the PR with code checks. These old version numbers don't
> mean that these version have to be supported and compatible. If users
> have I issues we always advise to use the latest versions of everything.
>
> IMHO this shouldn't block a release.
>
> Am 04.06.20 um 17:14 schrieb Chris Brody:
> > I would favor updating the minimum Cordova requirement in both
> package.json
> > and plugin.xml, as I just commented in PR #685. I wish I would have seen
> it
> > before PR #685 was merged.
> >
> >
> > On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz <ni...@apache.org>
> wrote:
> >
> >> I merged two outstanding patches just now.
> >>
> >> If no reviews or concern come up, I will start the release in a few
> hours.
> >>
> >> June 2, 2020 8:31 PM, "Niklas Merz" <ni...@apache.org> wrote:
> >>
> >>> Hi all,
> >>>
> >>> since cordova-ios 6.0 was released recently the inappbrowser plugin
> does
> >> not work properly because
> >>> of the removal of UIWebView. I would suggest we do a plugin *release as
> >> soon as possible*.
> >>>
> >>> Since we already merged some major changes (including the UIWebview
> >> removal) this will be a major
> >>> release.
> >>>
> >>> Does anyone have a reason to delay the release?
> >>>
> >>> From my personal use of the plugin to pending PRs would be helpfull for
> >> this release, but they need
> >>> reviews. I would not delay the release for them and proceed without
> >> merging them.
> >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/688
> >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/656
> >>>
> >>> Any other outstanding patches to land?
> >>>
> >>> If not, I will start the release tomorrow.
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by Niklas Merz <ni...@apache.org>.
Correct me if I am wrong, but I don't think we want to update the
dependency versions to the current ones. It's just another version we
have to track and update.

I must say I don't really know what they are for and would love to learn
about that.

The PR updates them to be consistent and working with a bare minimum
like said in the PR with code checks. These old version numbers don't
mean that these version have to be supported and compatible. If users
have I issues we always advise to use the latest versions of everything.

IMHO this shouldn't block a release.

Am 04.06.20 um 17:14 schrieb Chris Brody:
> I would favor updating the minimum Cordova requirement in both package.json
> and plugin.xml, as I just commented in PR #685. I wish I would have seen it
> before PR #685 was merged.
> 
> 
> On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz <ni...@apache.org> wrote:
> 
>> I merged two outstanding patches just now.
>>
>> If no reviews or concern come up, I will start the release in a few hours.
>>
>> June 2, 2020 8:31 PM, "Niklas Merz" <ni...@apache.org> wrote:
>>
>>> Hi all,
>>>
>>> since cordova-ios 6.0 was released recently the inappbrowser plugin does
>> not work properly because
>>> of the removal of UIWebView. I would suggest we do a plugin *release as
>> soon as possible*.
>>>
>>> Since we already merged some major changes (including the UIWebview
>> removal) this will be a major
>>> release.
>>>
>>> Does anyone have a reason to delay the release?
>>>
>>> From my personal use of the plugin to pending PRs would be helpfull for
>> this release, but they need
>>> reviews. I would not delay the release for them and proceed without
>> merging them.
>>> https://github.com/apache/cordova-plugin-inappbrowser/pull/688
>>> https://github.com/apache/cordova-plugin-inappbrowser/pull/656
>>>
>>> Any other outstanding patches to land?
>>>
>>> If not, I will start the release tomorrow.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by Chris Brody <ch...@gmail.com>.
I would favor updating the minimum Cordova requirement in both package.json
and plugin.xml, as I just commented in PR #685. I wish I would have seen it
before PR #685 was merged.


On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz <ni...@apache.org> wrote:

> I merged two outstanding patches just now.
>
> If no reviews or concern come up, I will start the release in a few hours.
>
> June 2, 2020 8:31 PM, "Niklas Merz" <ni...@apache.org> wrote:
>
> > Hi all,
> >
> > since cordova-ios 6.0 was released recently the inappbrowser plugin does
> not work properly because
> > of the removal of UIWebView. I would suggest we do a plugin *release as
> soon as possible*.
> >
> > Since we already merged some major changes (including the UIWebview
> removal) this will be a major
> > release.
> >
> > Does anyone have a reason to delay the release?
> >
> > From my personal use of the plugin to pending PRs would be helpfull for
> this release, but they need
> > reviews. I would not delay the release for them and proceed without
> merging them.
> > https://github.com/apache/cordova-plugin-inappbrowser/pull/688
> > https://github.com/apache/cordova-plugin-inappbrowser/pull/656
> >
> > Any other outstanding patches to land?
> >
> > If not, I will start the release tomorrow.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by Niklas Merz <ni...@apache.org>.
I merged two outstanding patches just now. 

If no reviews or concern come up, I will start the release in a few hours.

June 2, 2020 8:31 PM, "Niklas Merz" <ni...@apache.org> wrote:

> Hi all,
> 
> since cordova-ios 6.0 was released recently the inappbrowser plugin does not work properly because
> of the removal of UIWebView. I would suggest we do a plugin *release as soon as possible*.
> 
> Since we already merged some major changes (including the UIWebview removal) this will be a major
> release.
> 
> Does anyone have a reason to delay the release?
> 
> From my personal use of the plugin to pending PRs would be helpfull for this release, but they need
> reviews. I would not delay the release for them and proceed without merging them.
> https://github.com/apache/cordova-plugin-inappbrowser/pull/688
> https://github.com/apache/cordova-plugin-inappbrowser/pull/656
> 
> Any other outstanding patches to land?
> 
> If not, I will start the release tomorrow.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by Niklas Merz <ni...@apache.org>.
Then I will start the release process without further changes or PRs merged this evening (in about 12 hours).

> While it would be ideal to get this fixed, ideally by migrating to GitHub
actions, probably not worth holding up the release.

Good point. Let's get this release out and fix CI properly after that. Travis CI was enough pain while testing this and Github Actions work much better.


June 8, 2020 2:14 PM, "Chris Brody" <ch...@gmail.com> wrote:

> To be clear, I would definitely not favor blocking this release. Thanks
> again.
> 
> On Mon, Jun 8, 2020 at 8:12 AM Chris Brody <ch...@gmail.com> wrote:
> 
>> While it would be ideal to get this fixed, ideally by migrating to GitHub
>> actions, probably not worth holding up the release.
>> 
>> Thanks for your work on this.
>> 
>> On Mon, Jun 8, 2020 at 3:19 AM Niklas Merz <ni...@apache.org> wrote:
>> 
>>> The master branch is now ready for release.
>>> 
>>> While trying to get another PR in, I noticed that Travis CI is using an
>>> old version of cordova-ios (5.1.1) and Xcode 10. I tried to update that
>>> with partial success:
>>> https://github.com/apache/cordova-plugin-inappbrowser/pull/717 Has
>>> anybody an idea how to fix that?
>>> 
>>> Do you think we should do the upgrade for CI make sure it tests with the
>>> current iOS versions or release it as it is now because people are
>>> waiting urgently for that version?
>>> 
>>> Am 02.06.20 um 20:31 schrieb Niklas Merz:
>>>> Hi all,
>>>> 
>>>> since cordova-ios 6.0 was released recently the inappbrowser plugin
>>> does not work properly because of the removal of UIWebView. I would
>>> suggest we do a plugin *release as soon as possible*.
>>>> 
>>>> Since we already merged some major changes (including the UIWebview
>>> removal) this will be a major release.
>>>> 
>>>> Does anyone have a reason to delay the release?
>>>> 
>>>> From my personal use of the plugin to pending PRs would be helpfull
>>> for this release, but they need reviews. I would not delay the release
>>> for them and proceed without merging them.
>>>> https://github.com/apache/cordova-plugin-inappbrowser/pull/688
>>>> https://github.com/apache/cordova-plugin-inappbrowser/pull/656
>>>> 
>>>> Any other outstanding patches to land?
>>>> 
>>>> If not, I will start the release tomorrow.
>>>> 
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>>> For additional commands, e-mail: dev-help@cordova.apache.org
>>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>> For additional commands, e-mail: dev-help@cordova.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by Chris Brody <ch...@gmail.com>.
To be clear, I would definitely not favor blocking this release. Thanks
again.


On Mon, Jun 8, 2020 at 8:12 AM Chris Brody <ch...@gmail.com> wrote:

> While it would be ideal to get this fixed, ideally by migrating to GitHub
> actions, probably not worth holding up the release.
>
> Thanks for your work on this.
>
>
> On Mon, Jun 8, 2020 at 3:19 AM Niklas Merz <ni...@apache.org> wrote:
>
>> The master branch is now ready for release.
>>
>> While trying to get another PR in, I noticed that Travis CI is using an
>> old version of cordova-ios (5.1.1) and Xcode 10. I tried to update that
>> with partial success:
>> https://github.com/apache/cordova-plugin-inappbrowser/pull/717 Has
>> anybody an idea how to fix that?
>>
>> Do you think we should do the upgrade for CI make sure it tests with the
>> current iOS versions or release it as it is now because people are
>> waiting urgently for that version?
>>
>> Am 02.06.20 um 20:31 schrieb Niklas Merz:
>> > Hi all,
>> >
>> > since cordova-ios 6.0 was released recently the inappbrowser plugin
>> does not work properly because of the removal of UIWebView. I would
>> suggest we do a plugin *release as soon as possible*.
>> >
>> > Since we already merged some major changes (including the UIWebview
>> removal) this will be a major release.
>> >
>> > Does anyone have a reason to delay the release?
>> >
>> > From my personal use of the plugin to pending PRs would be helpfull
>> for this release, but they need reviews. I would not delay the release
>> for them and proceed without merging them.
>> > https://github.com/apache/cordova-plugin-inappbrowser/pull/688
>> > https://github.com/apache/cordova-plugin-inappbrowser/pull/656
>> >
>> > Any other outstanding patches to land?
>> >
>> > If not, I will start the release tomorrow.
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > For additional commands, e-mail: dev-help@cordova.apache.org
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>

Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by Chris Brody <ch...@gmail.com>.
While it would be ideal to get this fixed, ideally by migrating to GitHub
actions, probably not worth holding up the release.

Thanks for your work on this.


On Mon, Jun 8, 2020 at 3:19 AM Niklas Merz <ni...@apache.org> wrote:

> The master branch is now ready for release.
>
> While trying to get another PR in, I noticed that Travis CI is using an
> old version of cordova-ios (5.1.1) and Xcode 10. I tried to update that
> with partial success:
> https://github.com/apache/cordova-plugin-inappbrowser/pull/717 Has
> anybody an idea how to fix that?
>
> Do you think we should do the upgrade for CI make sure it tests with the
> current iOS versions or release it as it is now because people are
> waiting urgently for that version?
>
> Am 02.06.20 um 20:31 schrieb Niklas Merz:
> > Hi all,
> >
> > since cordova-ios 6.0 was released recently the inappbrowser plugin
> does not work properly because of the removal of UIWebView. I would
> suggest we do a plugin *release as soon as possible*.
> >
> > Since we already merged some major changes (including the UIWebview
> removal) this will be a major release.
> >
> > Does anyone have a reason to delay the release?
> >
> > From my personal use of the plugin to pending PRs would be helpfull
> for this release, but they need reviews. I would not delay the release
> for them and proceed without merging them.
> > https://github.com/apache/cordova-plugin-inappbrowser/pull/688
> > https://github.com/apache/cordova-plugin-inappbrowser/pull/656
> >
> > Any other outstanding patches to land?
> >
> > If not, I will start the release tomorrow.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Re: [DISCUSS] InAppBrowser 4.0.0 major release

Posted by Niklas Merz <ni...@apache.org>.
The master branch is now ready for release.

While trying to get another PR in, I noticed that Travis CI is using an
old version of cordova-ios (5.1.1) and Xcode 10. I tried to update that
with partial success:
https://github.com/apache/cordova-plugin-inappbrowser/pull/717 Has
anybody an idea how to fix that?

Do you think we should do the upgrade for CI make sure it tests with the
current iOS versions or release it as it is now because people are
waiting urgently for that version?

Am 02.06.20 um 20:31 schrieb Niklas Merz:
> Hi all,
>
> since cordova-ios 6.0 was released recently the inappbrowser plugin
does not work properly because of the removal of UIWebView. I would
suggest we do a plugin *release as soon as possible*.
>
> Since we already merged some major changes (including the UIWebview
removal) this will be a major release.
>
> Does anyone have a reason to delay the release?
>
> From my personal use of the plugin to pending PRs would be helpfull
for this release, but they need reviews. I would not delay the release
for them and proceed without merging them.
> https://github.com/apache/cordova-plugin-inappbrowser/pull/688
> https://github.com/apache/cordova-plugin-inappbrowser/pull/656
>
> Any other outstanding patches to land?
>
> If not, I will start the release tomorrow.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org