You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/16 12:32:06 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #12072: feat(queries): security perm simplification
dpgaspar opened a new pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (fcd13ae) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.34%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 64.21% -3.35%
==========================================
Files 959 477 -482
Lines 47154 29417 -17737
Branches 4609 0 -4609
==========================================
- Hits 31857 18891 -12966
+ Misses 15185 10526 -4659
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.21% <9.09%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| [superset-frontend/src/utils/copy.ts](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvcHkudHM=) | | |
| [...et-frontend/src/components/RefreshChartOverlay.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaENoYXJ0T3ZlcmxheS50c3g=) | | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | | |
| [.../src/explore/components/controls/BoundsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Cb3VuZHNDb250cm9sLmpzeA==) | | |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...fcd13ae](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `0.04%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 67.51% -0.05%
==========================================
Files 959 960 +1
Lines 47154 47185 +31
Branches 4609 4609
==========================================
Hits 31857 31857
- Misses 15185 15216 +31
Partials 112 112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.11% <ø> (-0.02%)` | :arrow_down: |
| javascript | `62.67% <ø> (ø)` | |
| python | `64.24% <9.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (-1.59%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `83.03% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `1.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 63.69% 62.67% -1.03%
==========================================
Files 959 483 -476
Lines 47140 17754 -29386
Branches 4609 4609
==========================================
- Hits 30025 11127 -18898
+ Misses 16931 6443 -10488
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.67% <ø> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | | |
| [...erset/migrations/versions/ab8c66efdd01\_resample.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjhjNjZlZmRkMDFfcmVzYW1wbGUucHk=) | | |
| [...notation\_layers/annotations/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
| [...ations/versions/937d04c16b64\_update\_datasources.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy85MzdkMDRjMTZiNjRfdXBkYXRlX2RhdGFzb3VyY2VzLnB5) | | |
| [superset/reports/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9jcmVhdGUucHk=) | | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | | |
| [superset/examples/long\_lat.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbG9uZ19sYXQucHk=) | | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | | |
| [superset/datasets/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | | |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | | |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (fcd13ae) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.14%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 63.40% -4.15%
==========================================
Files 959 477 -482
Lines 47154 29415 -17739
Branches 4609 0 -4609
==========================================
- Hits 31857 18652 -13205
+ Misses 15185 10763 -4422
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.40% <9.09%> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.22% <0.00%> (-6.28%)` | :arrow_down: |
| ... and [497 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...fcd13ae](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.15%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 63.40% -4.16%
==========================================
Files 959 960 +1
Lines 47154 47171 +17
Branches 4609 4609
==========================================
- Hits 31857 29908 -1949
- Misses 15185 17079 +1894
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <ø> (ø)` | |
| python | `63.84% <9.09%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.90%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 63.65% -3.91%
==========================================
Files 959 960 +1
Lines 47154 47171 +17
Branches 4609 4609
==========================================
- Hits 31857 30026 -1831
- Misses 15185 16961 +1776
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <ø> (ø)` | |
| python | `64.24% <9.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (fcd13ae) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.34%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 64.21% -3.35%
==========================================
Files 959 477 -482
Lines 47154 29417 -17737
Branches 4609 0 -4609
==========================================
- Hits 31857 18891 -12966
+ Misses 15185 10526 -4659
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.21% <9.09%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | | |
| [...ntend/src/components/Checkbox/Checkbox.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3guc3Rvcmllcy5qc3g=) | | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | | |
| [...s/ErrorMessage/getErrorMessageComponentRegistry.ts](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL2dldEVycm9yTWVzc2FnZUNvbXBvbmVudFJlZ2lzdHJ5LnRz) | | |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...fcd13ae](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (fcd13ae) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.72%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 63.83% -3.73%
==========================================
Files 959 477 -482
Lines 47154 29417 -17737
Branches 4609 0 -4609
==========================================
- Hits 31857 18779 -13078
+ Misses 15185 10638 -4547
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.83% <9.09%> (-0.48%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...fcd13ae](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `0.30%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 63.69% 63.38% -0.31%
==========================================
Files 959 960 +1
Lines 47140 47169 +29
Branches 4609 4609
==========================================
- Hits 30025 29898 -127
- Misses 16931 17087 +156
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.67% <ø> (ø)` | |
| python | `63.81% <9.09%> (-0.50%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.80% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (fcd13ae) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.37%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 64.18% -3.38%
==========================================
Files 959 477 -482
Lines 47154 29417 -17737
Branches 4609 0 -4609
==========================================
- Hits 31857 18881 -12976
+ Misses 15185 10536 -4649
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.18% <9.09%> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| [...frontend/src/profile/components/CreatedContent.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9DcmVhdGVkQ29udGVudC50c3g=) | | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | | |
| ... and [482 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...fcd13ae](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (fcd13ae) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.34%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 64.21% -3.35%
==========================================
Files 959 477 -482
Lines 47154 29417 -17737
Branches 4609 0 -4609
==========================================
- Hits 31857 18891 -12966
+ Misses 15185 10526 -4659
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.21% <9.09%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | | |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | | |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...fcd13ae](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.90%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 63.65% -3.91%
==========================================
Files 959 960 +1
Lines 47154 47171 +17
Branches 4609 4609
==========================================
- Hits 31857 30026 -1831
- Misses 15185 16961 +1776
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <ø> (ø)` | |
| python | `64.24% <9.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `0.14%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 67.41% -0.15%
==========================================
Files 959 960 +1
Lines 47154 47185 +31
Branches 4609 4609
==========================================
- Hits 31857 31809 -48
- Misses 15185 15260 +75
- Partials 112 116 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.63% <ø> (-0.49%)` | :arrow_down: |
| javascript | `62.67% <ø> (ø)` | |
| python | `64.24% <9.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.11% <0.00%> (-3.85%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <0.00%> (-2.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `38.42% <0.00%> (-2.48%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (-1.59%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.16% <0.00%> (-1.17%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.12%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 67.55% 63.43% -4.13%
==========================================
Files 959 960 +1
Lines 47154 47171 +17
Branches 4609 4609
==========================================
- Hits 31857 29924 -1933
- Misses 15185 17063 +1878
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <ø> (ø)` | |
| python | `63.89% <9.09%> (-0.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `0.30%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 63.69% 63.38% -0.31%
==========================================
Files 959 960 +1
Lines 47140 47171 +31
Branches 4609 4609
==========================================
- Hits 30025 29899 -126
- Misses 16931 17088 +157
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.67% <ø> (ø)` | |
| python | `63.81% <9.09%> (-0.50%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.80% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12072: feat(queries): security perm simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12072:
URL: https://github.com/apache/incubator-superset/pull/12072#issuecomment-746265938
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=h1) Report
> Merging [#12072](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=desc) (cf34a6c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `0.45%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
- Coverage 63.69% 63.24% -0.46%
==========================================
Files 959 960 +1
Lines 47140 47169 +29
Branches 4609 4609
==========================================
- Hits 30025 29830 -195
- Misses 16931 17155 +224
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.67% <ø> (ø)` | |
| python | `63.58% <9.09%> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...versions/e37912a26567\_security\_converge\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMzc5MTJhMjY1Njdfc2VjdXJpdHlfY29udmVyZ2VfcXVlcmllcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/12072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=footer). Last update [2302adb...cf34a6c](https://codecov.io/gh/apache/incubator-superset/pull/12072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org